[Gnash-commit] gnash ChangeLog testsuite/misc-swfc.all/soft_re...

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  07/08/29 10:54:17

Modified files:
        .              : ChangeLog 
        testsuite/misc-swfc.all: soft_reference_test1.sc 

Log message:
                * testsuite/misc-swfc.all/soft_reference_test1.sc: add some
                  comments as to why Gnash fails.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.4145&r2=1.4146
http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/misc-swfc.all/soft_reference_test1.sc?cvsroot=gnash&r1=1.5&r2=1.6

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.4145
retrieving revision 1.4146
diff -u -b -r1.4145 -r1.4146
--- ChangeLog   29 Aug 2007 07:41:36 -0000      1.4145
+++ ChangeLog   29 Aug 2007 10:54:17 -0000      1.4146
@@ -1,3 +1,8 @@
+2007-08-29 Sandro Santilli <address@hidden>
+
+       * testsuite/misc-swfc.all/soft_reference_test1.sc: add some
+         comments as to why Gnash fails.
+
 2007-08-29 Zou Lunkai <address@hidden>
        
        * testsuite/misc-swfc.all/soft_reference_test1.sc: new focused

Index: testsuite/misc-swfc.all/soft_reference_test1.sc
===================================================================
RCS file: /sources/gnash/gnash/testsuite/misc-swfc.all/soft_reference_test1.sc,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -b -r1.5 -r1.6
--- testsuite/misc-swfc.all/soft_reference_test1.sc     29 Aug 2007 10:43:49 
-0000      1.5
+++ testsuite/misc-swfc.all/soft_reference_test1.sc     29 Aug 2007 10:54:17 
-0000      1.6
@@ -68,6 +68,9 @@
     check(typeof(mc)=='movieclip');  
     check(typeof(mcRef)=='movieclip'); 
     check(mc == _level0.mc);    
+    // Gnash bug:
+    //   Target of the sprite mcRef points to changed, so seeking
+    //   for the new target fails (_level0.changed doesn't exist)
     xcheck(mcRef == _level0.mc);
   .end
 
@@ -113,6 +116,13 @@
     _root.createEmptyMovieClip("mc2", 40);
 
     check(typeof(mcRef)=='movieclip');
+    // Gnash bug:
+    //   Target of the sprite pointed to by mcRef is
+    //   not the one used on creation (_level0.mc1) but the one
+    //   subsequently changed to by effect of _name assignment: _level0.mc2.
+    //   Thus, when finding a *new* character (the old one was unloaded)
+    //   we find the *new* _level0.mc2.
+    //   Should be fixed in the same way as for the bug exposed in frame 5
     xcheck(mcRef.valueOf() == null) 
     
     // release resources after testing
@@ -136,8 +146,8 @@
     check_equals(mcContainer[1].getDepth(), 51);
     check_equals(mc1.getDepth(), 50);
     
-    mc1._name = "mc2";
-    mcRef = mc2;
+    mc1._name = "mc2"; // char at depth 50 changes name
+    mcRef = mc2; // mcRef now points to char at depth 50, and target 
_level0.mc2
     
     check(typeof(mcRef)=='movieclip');
     check_equals(mcRef.getDepth(), 50);
@@ -147,6 +157,10 @@
     _root.createEmptyMovieClip("mc2", 60);
 
     check(typeof(mcRef)=='movieclip');
+
+    // Gnash bug:
+    //   Still the same bug: the ref uses *current* target instead of the one
+    //   as of creation time.
     xcheck(mcRef == _level0.mc1);
     
     _root.totals();