[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Gnash-commit] gnash ChangeLog server/stream.h server/stream.cpp
From: |
Chad Musick |
Subject: |
Re: [Gnash-commit] gnash ChangeLog server/stream.h server/stream.cpp |
Date: |
Fri, 24 Aug 2007 19:33:38 +0900 |
I'm not sure if align() should be called -- I mimicked the read_fixed()
function in this.
On Fri, 2007-08-24 at 09:55 +0200, strk wrote:
> On Fri, Aug 24, 2007 at 05:45:52AM +0000, Chad Musick wrote:
>
> > + float read_short_fixed();
>
> Please document the functions you add, a single line would do.
>
> > + float stream::read_short_fixed()
> > + {
> > + m_unused_bits = 0;
> > + return (float) m_input->read_le16();
> > + }
> >
> > void stream::align() { m_unused_bits = 0; m_current_byte = 0; }
>
> Should you call align() instead of just setting m_unused_bits to 0 ?
>
> --strk;