[Gnash-commit] gnash ChangeLog backend/sound_handler_gst.cpp b... [release_0_8_1]

[Tomas Groth]

CVSROOT:        /sources/gnash
Module name:    gnash
Branch:         release_0_8_1
Changes by:     Tomas Groth <tgc>       07/08/15 15:02:42

Modified files:
        .              : ChangeLog 
        backend        : sound_handler_gst.cpp sound_handler_sdl.cpp 

Log message:
                * backend/sound_handler_{sdl,gst}.cpp: Removed primitive
                  sync'ing code since it resulted in bad audio.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&only_with_tag=release_0_8_1&r1=1.3971.2.17&r2=1.3971.2.18
http://cvs.savannah.gnu.org/viewcvs/gnash/backend/sound_handler_gst.cpp?cvsroot=gnash&only_with_tag=release_0_8_1&r1=1.59&r2=1.59.2.1
http://cvs.savannah.gnu.org/viewcvs/gnash/backend/sound_handler_sdl.cpp?cvsroot=gnash&only_with_tag=release_0_8_1&r1=1.79&r2=1.79.2.1

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.3971.2.17
retrieving revision 1.3971.2.18
diff -u -b -r1.3971.2.17 -r1.3971.2.18
--- ChangeLog   11 Aug 2007 03:12:14 -0000      1.3971.2.17
+++ ChangeLog   15 Aug 2007 15:02:40 -0000      1.3971.2.18
@@ -1,3 +1,8 @@
+2007-08-15 Tomas Groth Christensen <address@hidden>
+
+       * backend/sound_handler_{sdl,gst}.cpp: Removed primitive
+         sync'ing code since it resulted in bad audio.
+
 2007-08-10 Sandro Santilli <address@hidden>
 
        * gui/Makefile.am: fix build of sdl/cairo

Index: backend/sound_handler_gst.cpp
===================================================================
RCS file: /sources/gnash/gnash/backend/sound_handler_gst.cpp,v
retrieving revision 1.59
retrieving revision 1.59.2.1
diff -u -b -r1.59 -r1.59.2.1
--- backend/sound_handler_gst.cpp       8 Aug 2007 10:39:50 -0000       1.59
+++ backend/sound_handler_gst.cpp       15 Aug 2007 15:02:41 -0000      1.59.2.1
@@ -20,7 +20,7 @@
 // Based on sound_handler_sdl.cpp by Thatcher Ulrich http://tulrich.com 2003
 // which has been donated to the Public Domain.
 
-/* $Id: sound_handler_gst.cpp,v 1.59 2007/08/08 10:39:50 tgc Exp $ */
+/* $Id: sound_handler_gst.cpp,v 1.59.2.1 2007/08/15 15:02:41 tgc Exp $ */
 
 #ifdef HAVE_CONFIG_H
 #include "config.h"
@@ -275,13 +275,8 @@
        sound_data* sounddata = m_sound_data[sound_handle];
 
        // If this is called from a streamsoundblocktag, we only start if this
-       // sound isn't already playing. If a active_sound-struct is existing we
-       // assume it is also playing. If necessary we do some sync'ing
+       // sound isn't already playing.
        if (start_position > 0 && sounddata->m_gst_elements.size() > 0) {
-               // This is the ugly sync'ing. If the renderer-sync'ing  to the 
timeline
-               // works, this should only be needed when we're 
position-jumping in streams.
-               int diff = abs(sounddata->m_gst_elements[0]->position - 
start_position);
-               if (diff > 2000) sounddata->m_gst_elements[0]->position = 
start_position;
                return;
        }
        // Make sure sound actually got some data

Index: backend/sound_handler_sdl.cpp
===================================================================
RCS file: /sources/gnash/gnash/backend/sound_handler_sdl.cpp,v
retrieving revision 1.79
retrieving revision 1.79.2.1
diff -u -b -r1.79 -r1.79.2.1
--- backend/sound_handler_sdl.cpp       8 Aug 2007 10:39:50 -0000       1.79
+++ backend/sound_handler_sdl.cpp       15 Aug 2007 15:02:41 -0000      1.79.2.1
@@ -18,7 +18,7 @@
 // Based on sound_handler_sdl.cpp by Thatcher Ulrich http://tulrich.com 2003
 // which has been donated to the Public Domain.
 
-// $Id: sound_handler_sdl.cpp,v 1.79 2007/08/08 10:39:50 tgc Exp $
+// $Id: sound_handler_sdl.cpp,v 1.79.2.1 2007/08/15 15:02:41 tgc Exp $
 
 #ifdef HAVE_CONFIG_H
 #include "config.h"
@@ -243,13 +243,8 @@
        sound_data* sounddata = m_sound_data[sound_handle];
 
        // If this is called from a streamsoundblocktag, we only start if this
-       // sound isn't already playing. If a active_sound-struct is existing we
-       // assume it is also playing. If necessary we do some sync'ing
+       // sound isn't already playing.
        if (start_position > 0 && sounddata->m_active_sounds.size() > 0) {
-               // This is the ugly sync'ing. If the renderer-sync'ing  to the 
timeline
-               // works, this should only be needed when we're 
position-jumping in streams.
-               int diff = abs(sounddata->m_active_sounds[0]->position - 
start_position);
-               if (diff > 2000) sounddata->m_active_sounds[0]->position = 
start_position;
                return;
        }