gnash-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-commit] gnash ChangeLog server/array.cpp server/array.h...


From: Sandro Santilli
Subject: Re: [Gnash-commit] gnash ChangeLog server/array.cpp server/array.h...
Date: Tue, 14 Aug 2007 05:07:55 +0200

On Mon, Aug 13, 2007 at 10:53:07AM +0800, zou lunkai wrote:
> >+       unsigned int optnum = props->size();
> >+       as_cmp_fn cmp[optnum];
> >+       as_cmp_fn eq[optnum];
> 
> >+       uint8_t flgs[optnum];
> 
> A question, is it good practice to rely on VLA(variable length array)?
>  Note that even VC8 compiler does not support this feature.
> 
> I guess we should not rely on it, which is compiler dependent(based on
> google search) and only occurs in array.cpp.  What about replace it
> with some STL containers?

Just for the record:
http://savannah.gnu.org/patch/index.php?6149
"Replace VLAs in array.cpp with std containers"

--strk;





reply via email to

[Prev in Thread] Current Thread [Next in Thread]