Re: [Gnash-commit] gnash ChangeLog server/character.h server/dlist...

[zou lunkai]

> > -             boost::mutex::scoped_lock lock(_frameDepthsMutex);
> > +             //boost::mutex::scoped_lock lock(_frameDepthsMutex);

ops, I did not do this purposely, it was an accident. I'll correct it soon.

 For the new timeline design, I bet there are some other places that
need cleanups, but should be better than the old ones in general.

 I'll update the wiki first, and wait a few days to see if there is
any regression and then follow up some other cleanups.


On 8/10/07, strk <address@hidden> wrote:
> On Thu, Aug 09, 2007 at 12:18:08PM +0000, Zou Lunkai wrote:
>
> > Index: server/parser/Timeline.h
> > ===================================================================
> > RCS file: /sources/gnash/gnash/server/parser/Timeline.h,v
> > retrieving revision 1.5
> > retrieving revision 1.6
> > diff -u -b -r1.5 -r1.6
> > --- server/parser/Timeline.h  1 Jul 2007 10:54:33 -0000       1.5
> > +++ server/parser/Timeline.h  9 Aug 2007 12:18:06 -0000       1.6
> > @@ -94,7 +94,7 @@
> >       ///
> >       void closeFrame()
> >       {
> > -             boost::mutex::scoped_lock lock(_frameDepthsMutex);
> > +             //boost::mutex::scoped_lock lock(_frameDepthsMutex);
>
> Isn't Timeline set by parser thread and used by playback thread anymore ?
> That's why the mutex was there... (something which is hard to test with
> a testcase, being time-based pending bug)
>
> (I belive getFrameDeptsh() should also lock, didn't notice if you
> changed that or was already bogus).
>
> The methods description tell which methods should lock and which not.
>
> --strk;
>