Re: [Gnash-commit] gnash ChangeLog gui/Player.cpp gui/Player.h gui...

[strk]

On Thu, Jul 26, 2007 at 12:51:57AM -0600, Rob Savoye wrote:
> On Thu, Jul 26, 2007 at 07:20:17AM +0200, Sandro Santilli wrote:
> 
> > With this patch, libgnashplayer might be built again, with a set of 
> > gui/renderer libraries linked
> > to it (either statically or dynamically) as long as corresponding GUI_XXX 
> > defines are provided
> > to Player.cpp so it knows which guis lib symbols to reference and which not.
> 
>  This will break any attempts at dynamic loading, as Player.cpp gets compiled
> with different gui configurations. So player has to be part of the
> "gui_render" library that gets built, and not standalone.

I actually added to Player.cpp the logic to select GUI at runtime.
What I'm stuck in now is we can't include headers from gtk *and* kde
in the same .cpp due to name clashes. I'd abstract Gui creation out
similarly to what is done in render_handler_xxx.h (only a C-linkage
creation function is exposed)

> I'm still at OSCON

Could you create a wiki account to davr from there ?

> for a few more days, but I guess I'll have to fix this when I get back. This
> "fix" as it is now will only work with the current config where the libs get
> get linked in to the executable.

Yes, this is the idea for 0.8.1, once the abstraction for creating GUI
is there though, changing to a plugin-style shouldn't be too hard.


--strk;