[Gnash-commit] gnash/cygnal/ACT Change_Log.txt Handle.hpp List...

[Eric Hughes]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Eric Hughes <eh9>       07/07/19 18:29:34

Modified files:
        cygnal/ACT     : Change_Log.txt Handle.hpp Listen.T.cpp 
                         Pause_Demon.cpp Pause_Demon.hpp Service.hpp 

Log message:
        With apologies to strk, I unreverted a typedef forwarding change, which 
it turns out is true only with Microsoft-specific extensions enabled.  Added 
needed public declarations on these forwards.
        Added MSVC-portability comment in Pause_Demon.cpp.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/cygnal/ACT/Change_Log.txt?cvsroot=gnash&r1=1.2&r2=1.3
http://cvs.savannah.gnu.org/viewcvs/gnash/cygnal/ACT/Handle.hpp?cvsroot=gnash&r1=1.3&r2=1.4
http://cvs.savannah.gnu.org/viewcvs/gnash/cygnal/ACT/Listen.T.cpp?cvsroot=gnash&r1=1.1&r2=1.2
http://cvs.savannah.gnu.org/viewcvs/gnash/cygnal/ACT/Pause_Demon.cpp?cvsroot=gnash&r1=1.1&r2=1.2
http://cvs.savannah.gnu.org/viewcvs/gnash/cygnal/ACT/Pause_Demon.hpp?cvsroot=gnash&r1=1.1&r2=1.2
http://cvs.savannah.gnu.org/viewcvs/gnash/cygnal/ACT/Service.hpp?cvsroot=gnash&r1=1.4&r2=1.5

Patches:
Index: Change_Log.txt
===================================================================
RCS file: /sources/gnash/gnash/cygnal/ACT/Change_Log.txt,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -b -r1.2 -r1.3
--- Change_Log.txt      10 Jul 2007 14:09:08 -0000      1.2
+++ Change_Log.txt      19 Jul 2007 18:29:34 -0000      1.3
@@ -1,10 +1,14 @@
 Change Log for GNU Cygnal, Module ACT
 =====================================
 
+2007-07-19 Eric Hughes <address@hidden>
+       * Handle.hpp: Added forwarding typedefs in Vector_with_Handle_Index.
+       * Pause_Demon.cpp: Added important portability note.
+
 2007-07-10 Eric Hughes <address@hidden>
        * Pause_Demon.[hc]pp: Renamed from Pause_Service.[hc]pp.
-       * ACT/unit_tests/Test_Scheduler.cpp: Added finished_at_bound() to 
scheduler test aspect.  (Re-)Wrote a proper pause demon test.
-       * ACT/ACT.doxygen.txt: Added more environment documentation.
+       * unit_tests/Test_Scheduler.cpp: Added finished_at_bound() to scheduler 
test aspect.  (Re-)Wrote a proper pause demon test.
+       * ACT.doxygen.txt: Added more environment documentation.
 
 2007-07-09 Eric Hughes <address@hidden>
        * Scheduler.hpp, Scheduler.cpp, Scheduler.T.cpp: Renamed scheduler 
category Service to Demon to get rid of a name collision.

Index: Handle.hpp
===================================================================
RCS file: /sources/gnash/gnash/cygnal/ACT/Handle.hpp,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -b -r1.3 -r1.4
--- Handle.hpp  18 Jul 2007 21:13:26 -0000      1.3
+++ Handle.hpp  19 Jul 2007 18:29:34 -0000      1.4
@@ -80,8 +80,15 @@
        class Vector_with_Handle_Index
                : public std::vector< T >
        {
+       private:
                typedef std::vector< T > Base ;         /// Our base class, 
defined for legibility.
 
+       public:
+               typedef typename Base::reference reference ;
+               typedef typename Base::const_reference const_reference ;
+               typedef typename Base::size_type size_type ;
+
+       private:
                inline reference operator[]( size_type n ) { throw 
std::exception() ; }                         /// Prohibit offset operation with 
unwrapped index
                inline const_reference operator[]( size_type n ) const { throw 
std::exception() ; }     /// Prohibit offset operation with unwrapped index
                inline reference at( size_type n ) { throw std::exception() ; } 
                                        /// Prohibit offset operation with 
unwrapped index

Index: Listen.T.cpp
===================================================================
RCS file: /sources/gnash/gnash/cygnal/ACT/Listen.T.cpp,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -b -r1.1 -r1.2

Index: Pause_Demon.cpp
===================================================================
RCS file: /sources/gnash/gnash/cygnal/ACT/Pause_Demon.cpp,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -b -r1.1 -r1.2
--- Pause_Demon.cpp     10 Jul 2007 14:09:08 -0000      1.1
+++ Pause_Demon.cpp     19 Jul 2007 18:29:34 -0000      1.2
@@ -18,9 +18,19 @@
 // Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
 //
 
-/// \file Pause_Demon.cpp
-///    \brief The Pause service suspends itself (and its thread) for a number 
of milliseconds 
-///            if the scheduling queue has no high-priority items.
+/**    \file Pause_Demon.cpp
+       \brief The Pause service suspends itself (and its thread) for a number 
of milliseconds 
+               if the scheduling queue has no high-priority items.
+
+       \par Warning: MSVC portability note
+               The code within this unit should be portable, since in relies 
upon Boost::Thread.
+               As of this writing, however, there's a flaw when working under 
MSVC.
+               For some reason, the Boost thread library disables thread 
support unless language extensions are turned on.
+               [This behavior is true with Boost 1.33.1; perhaps a later 
version may fix this.]
+               Ordinarily, it's hazardous to portability to enable any kind of 
extension in a Microsoft product.
+               Unfortunately, it has to be there as of the present writing to 
get this unit to compile.
+ */
+
 
 #include "Pause_Demon.hpp"
 #include <boost/thread/thread.hpp>

Index: Pause_Demon.hpp
===================================================================
RCS file: /sources/gnash/gnash/cygnal/ACT/Pause_Demon.hpp,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -b -r1.1 -r1.2

Index: Service.hpp
===================================================================
RCS file: /sources/gnash/gnash/cygnal/ACT/Service.hpp,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -b -r1.4 -r1.5