[Gnash-commit] gnash/cygnal/HTTP Change_Log.txt URI.cpp

[Eric Hughes]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Eric Hughes <eh9>       07/07/19 02:10:37

Modified files:
        cygnal/HTTP    : Change_Log.txt URI.cpp 

Log message:
        Fixed defect in URI scanning.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/cygnal/HTTP/Change_Log.txt?cvsroot=gnash&r1=1.1&r2=1.2
http://cvs.savannah.gnu.org/viewcvs/gnash/cygnal/HTTP/URI.cpp?cvsroot=gnash&r1=1.3&r2=1.4

Patches:
Index: Change_Log.txt
===================================================================
RCS file: /sources/gnash/gnash/cygnal/HTTP/Change_Log.txt,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -b -r1.1 -r1.2
--- Change_Log.txt      10 Jul 2007 14:09:10 -0000      1.1
+++ Change_Log.txt      19 Jul 2007 02:10:37 -0000      1.2
@@ -1,6 +1,9 @@
 Change Log for GNU Cygnal, Module HTTP
 ======================================
 
+2007-07-10 Eric Hughes <address@hidden>
+       * URI.cpp: Fixed defect with URI scanner consuming an extra character 
at end.
+
 2007-07-09 Eric Hughes <address@hidden>
        * unit_tests/Test_HTTP.cpp: Duplicated Invalid_Version_Request test 
into ordinary URI and *-URI forms.
        * HTTP_Parse.[hc]pp: Fixed defect in Request_Scanner, which wasn't 
looking explicitly for a space after the URI.  It was relying on the URI 
scanner to consume the next character, but since the URI scanner is used 
elsewhere, it should not silently consume anything other than the URI itself.  
Fixing this defect allowed the Invalid_Version_Request, *-version, to pass, but 
unmasked the defect in URI scanning.

Index: URI.cpp
===================================================================
RCS file: /sources/gnash/gnash/cygnal/HTTP/URI.cpp,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -b -r1.3 -r1.4
--- URI.cpp     10 Jul 2007 14:09:09 -0000      1.3
+++ URI.cpp     19 Jul 2007 02:10:37 -0000      1.4
@@ -450,10 +450,9 @@
                                return source_state() ;
                        //----------
                        label_done_unget_last_character:
-                               uri.r_URI.set_length( next_character - 
URI_begin - 1 ) ;
-                               if ( uri.r_URI.size() == 0 ) return set_bad() ;
-                               return set_completed() ;
-
+                               ++ n_left_to_process ;
+                               -- next_character ;
+                               // fall through
                        //----------
                        label_done:
                        case done: