[Gnash-commit] gnash ChangeLog server/asobj/Mouse.cpp testsuit...

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  07/07/13 19:24:16

Modified files:
        .              : ChangeLog 
        server/asobj   : Mouse.cpp 
        testsuite/actionscript.all: Mouse.as 

Log message:
                * server/asobj/Mouse.cpp: fix case of addListener and 
removeListener
                  methods, add TODO for fixing all.
                * testsuite/actionscript.all/Mouse.as: fix the test (case 
issue, and
                  poor comparisons).

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.3735&r2=1.3736
http://cvs.savannah.gnu.org/viewcvs/gnash/server/asobj/Mouse.cpp?cvsroot=gnash&r1=1.11&r2=1.12
http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/actionscript.all/Mouse.as?cvsroot=gnash&r1=1.8&r2=1.9

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.3735
retrieving revision 1.3736
diff -u -b -r1.3735 -r1.3736
--- ChangeLog   13 Jul 2007 19:13:47 -0000      1.3735
+++ ChangeLog   13 Jul 2007 19:24:15 -0000      1.3736
@@ -1,5 +1,12 @@
 2007-07-13 Sandro Santilli <address@hidden>
 
+       * server/asobj/Mouse.cpp: fix case of addListener and removeListener
+         methods, add TODO for fixing all.
+       * testsuite/actionscript.all/Mouse.as: fix the test (case issue, and
+         poor comparisons).
+
+2007-07-13 Sandro Santilli <address@hidden>
+
        * testsuite/actionscript.all/TextField.as: an hopefully complete
          testcase for the TextField class. Reveals a pattern in the
          TextField.prototype properties being created on first call to 

Index: server/asobj/Mouse.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/asobj/Mouse.cpp,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -b -r1.11 -r1.12
--- server/asobj/Mouse.cpp      1 Jul 2007 10:54:28 -0000       1.11
+++ server/asobj/Mouse.cpp      13 Jul 2007 19:24:15 -0000      1.12
@@ -39,9 +39,11 @@
 static void
 attachMouseInterface(as_object& o)
 {
-       o.init_member("addlistener", new builtin_function(mouse_addlistener));
+       // TODO: Mouse is an object, not a constructor ! Attach these interface 
to
+       //       the singleton Mouse object then !
+       o.init_member("addListener", new builtin_function(mouse_addlistener));
        o.init_member("hide", new builtin_function(mouse_hide));
-       o.init_member("removelistener", new 
builtin_function(mouse_removelistener));
+       o.init_member("removeListener", new 
builtin_function(mouse_removelistener));
        o.init_member("show", new builtin_function(mouse_show));
 }
 

Index: testsuite/actionscript.all/Mouse.as
===================================================================
RCS file: /sources/gnash/gnash/testsuite/actionscript.all/Mouse.as,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -b -r1.8 -r1.9
--- testsuite/actionscript.all/Mouse.as 1 Jul 2007 10:54:39 -0000       1.8
+++ testsuite/actionscript.all/Mouse.as 13 Jul 2007 19:24:15 -0000      1.9
@@ -20,19 +20,25 @@
 // compile this test case with Ming makeswf, and then
 // execute it like this gnash -1 -r 0 -v out.swf
 
-rcsid="$Id: Mouse.as,v 1.8 2007/07/01 10:54:39 bjacques Exp $";
+rcsid="$Id: Mouse.as,v 1.9 2007/07/13 19:24:15 strk Exp $";
 
 #include "check.as"
 
+xcheck_equals ( typeof(Mouse), 'object' );
+
 // Mouse object can't be instanciated !
 var mouseObj = new Mouse;
 xcheck_equals(mouseObj, undefined);
 
-// test the Mouse::addlistener method
-check (Mouse.addlistener != undefined);
 // test the Mouse::hide method
-check (Mouse.hide != undefined);
-// test the Mouse::removelistener method
-check (Mouse.removelistener != undefined);
+check_equals ( typeof(Mouse.hide), 'function' );
+
+#if OUTPUT_VERSION > 5
+// test addListner/removeListener, added in SWF6
+check_equals ( typeof(Mouse.removeListener), 'function' );
+check_equals ( typeof(Mouse.addListener), 'function' );
+#endif // OUTPUT_VERSION > 5
+
+
 // test the Mouse::show method
-check (Mouse.show != undefined);
+check_equals ( typeof(Mouse.show), 'function' );