Re: [Gnash-commit] gnash ChangeLog server/character.h server/butto...

[strk]

On Thu, Mar 08, 2007 at 07:45:18PM +0100, Udo Giacomozzi wrote:
> Thursday, March 8, 2007, 7:40:18 PM, you wrote:
> UG>         implement 'enabled' property for buttons
> 
> Some notes:
> 
> - I hope I got this getter-setter thing right

Can you try something like:

mybtn.enable = "a_string";
check_equals(typeof(mybtn.enable), 'string');

If the test suceeds (with the MM player), we can't 
use the getter-setter :(
I just found out we could *not* use it for ContextMenu.onSelect
and it's likely we can't use for onRollOver and friends too.
See actionscript.all/ContextMenu.as (I guess we can't use actionscript.all
for Button.as as we need a *real* button for testing that).

> - first of all, and most importantly, we need testcases for this, of
>   course ;)

(see above)

> - my own tests showed that the property works as expected

Please share them :)

> Other things I noticed:
> 
> - MM Flash gives sprites, that are placed *inside* the button,
>   standard names like "instance1", "instance2" and so on - no matter
>   if you give them names
>
> - Gnash does not give the sprites names. They show up like
>   "_level0.somebutton.".

We do this when placing objects on a DisplayList (so in sprite_instance only).
Not doine in buttons (We shall do there too).
Probably we'll have to use a "global" counter for instance naming, rather
then having a counter for each timeline.
I've seen swfdec has a nice testcase for this, worth looking at.

> - Probably because of this, _parent (which would be the button) inside
>   the sprite does not work

Most likely.

--strk;