Re[2]: [Gnash-commit] gnash ChangeLog gui/gtk.cpp server/sprite_insta...

[Udo Giacomozzi]

Hello Sandro,

Thursday, March 8, 2007, 12:34:25 PM, you wrote:
SS> Udo, you designed this set_invalidated() thing yourself.
SS> I had hard times understanding it, but finally got it, and found
SS> out that it is *important* that it is called *before* any change
SS> happens. I added this info to the corresponding header files
SS> (see NOTE in character::set_invalidated - character.h).

We made some progress on the original topic in IRC, but I reply to you
post anyway.

What you say is true, you apparently did understand set_invalidated().
However, execute_frame_tags() calls set_invalidated() automatically
(before changing anything). The differenct is that
execute_frame_tags() does this only when the display list really
changed.

BTW, a better name for the function would be "begin_invalidating()" or
"before_invalidating()" but I did not know this requirement at first..


SS> Now, we are *clearing* the DisplayList here, so set_invalidated
SS> must be called *before* that. What am I missing ?

In that case set_invalidated() was correct. I missed that line.
However, m_display_list.clear() appeared bogus to me.


>> Really? Clearing the displaylist calls onLoad? Or is this a typo?

SS> It's specified in a parameter, either does or doesn't, but on
SS> characters in the displayList, not on the sprite_instance containing it.
SS> Anyway, I've rolled this back to NOT call onUnload. Should work fine.

I was talking about onLoad vs. onUnload. I can't see what onLoad (not
onUnload) should be called when clearing. That's why I asked if it's a
typo.






Udo