[Gnash-commit] gnash ChangeLog backend/sound_handler_gst.cpp

[Tomas Groth]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Tomas Groth <tgc>       07/02/22 13:00:18

Modified files:
        .              : ChangeLog 
        backend        : sound_handler_gst.cpp 

Log message:
        * backend/sound_handler_gst.cpp: Removed the use of ffdec_mp3 since
          it isn't recommended by gstreamer. Added warnings if the used
          version of the fluendo-mp3-plugin is too low.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.2432&r2=1.2433
http://cvs.savannah.gnu.org/viewcvs/gnash/backend/sound_handler_gst.cpp?cvsroot=gnash&r1=1.32&r2=1.33

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.2432
retrieving revision 1.2433
diff -u -b -r1.2432 -r1.2433
--- ChangeLog   22 Feb 2007 11:39:43 -0000      1.2432
+++ ChangeLog   22 Feb 2007 13:00:17 -0000      1.2433
@@ -1,3 +1,9 @@
+2007-02-22 Tomas Groth Christensen <address@hidden>
+
+       * backend/sound_handler_gst.cpp: Removed the use of ffdec_mp3 since
+         it isn't recommended by gstreamer. Added warnings if the used
+         version of the fluendo-mp3-plugin is too low.
+
 2007-02-22 Udo Giacomozzi <address@hidden>
 
   * backend/render_handler_agg.cpp, backend/render_handler_agg_style.h:

Index: backend/sound_handler_gst.cpp
===================================================================
RCS file: /sources/gnash/gnash/backend/sound_handler_gst.cpp,v
retrieving revision 1.32
retrieving revision 1.33
diff -u -b -r1.32 -r1.33
--- backend/sound_handler_gst.cpp       21 Feb 2007 19:18:45 -0000      1.32
+++ backend/sound_handler_gst.cpp       22 Feb 2007 13:00:17 -0000      1.33
@@ -18,7 +18,7 @@
 // Based on sound_handler_sdl.cpp by Thatcher Ulrich http://tulrich.com 2003
 // which has been donated to the Public Domain.
 
-/* $Id: sound_handler_gst.cpp,v 1.32 2007/02/21 19:18:45 tgc Exp $ */
+/* $Id: sound_handler_gst.cpp,v 1.33 2007/02/22 13:00:17 tgc Exp $ */
 
 #ifdef HAVE_CONFIG_H
 #include "config.h"
@@ -321,14 +321,15 @@
        if (sounddata->format == FORMAT_MP3) { // || sounddata->format == 
FORMAT_VORBIS) {
 
                gst_element->decoder = gst_element_factory_make ("mad", NULL);
-               if (gst_element->decoder == NULL) gst_element->decoder = 
gst_element_factory_make ("ffdec_mp3", NULL);
                if (gst_element->decoder == NULL) {
                        gst_element->decoder = gst_element_factory_make 
("flump3dec", NULL);
-                       if (gst_element->decoder != NULL) 
gnash::log_warning("Fluendos mp3 plugin does not support flash streaming 
sounds.");
+                       if (gst_element->decoder != NULL && 
!gst_default_registry_check_feature_version("flump3dec", 0, 10, 4)) {
+                               gnash::log_warning("This version of fluendos 
mp3 plugin does not support flash streaming sounds, please upgrade to version 
0.10.4 or higher.");
+                       }
                }
                // Check if the element was correctly created
                if (!gst_element->decoder) {
-                       gnash::log_error("A gstreamer mp3-decoder element could 
not be created! You probably need to install a mp3-decoder plugin like 
gstreamer0.10-mad or gstreamer0.10-ffmpeg.");
+                       gnash::log_error("A gstreamer mp3-decoder element could 
not be created! You probably need to install a mp3-decoder plugin like 
gstreamer0.10-mad or gstreamer0.10-fluendo-mp3.");
                        return;
                }
                gst_bin_add (GST_BIN (gst_element->bin), gst_element->decoder);