[Gnash-commit] gnash ChangeLog server/sound.cpp server/sound.h

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  07/02/21 08:17:08

Modified files:
        .              : ChangeLog 
        server         : sound.cpp sound.h 

Log message:
                * server/sound.{h,cpp}: made start_sound_tag a "state"
                  tag. This seems to fixes eventSoundTest1.swf, altoguth
                  it's runner still fails (a bug in the tester, most likely).

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.2416&r2=1.2417
http://cvs.savannah.gnu.org/viewcvs/gnash/server/sound.cpp?cvsroot=gnash&r1=1.21&r2=1.22
http://cvs.savannah.gnu.org/viewcvs/gnash/server/sound.h?cvsroot=gnash&r1=1.6&r2=1.7

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.2416
retrieving revision 1.2417
diff -u -b -r1.2416 -r1.2417
--- ChangeLog   21 Feb 2007 07:57:17 -0000      1.2416
+++ ChangeLog   21 Feb 2007 08:17:08 -0000      1.2417
@@ -1,5 +1,8 @@
 2007-02-21 Sandro Santilli <address@hidden>
 
+       * server/sound.{h,cpp}: made start_sound_tag a "state"
+         tag. This seems to fixes eventSoundTest1.swf, altoguth
+         it's runner still fails (a bug in the tester, most likely).
        * testsuite/misc-ming.all/DrawingApiTestRunner.cpp:
          Fixed input filename (sorry guys).
 

Index: server/sound.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/sound.cpp,v
retrieving revision 1.21
retrieving revision 1.22
diff -u -b -r1.21 -r1.22
--- server/sound.cpp    21 Nov 2006 00:25:46 -0000      1.21
+++ server/sound.cpp    21 Feb 2007 08:17:08 -0000      1.22
@@ -97,10 +97,12 @@
 
 
 void
-start_sound_tag::execute(sprite_instance* /* m */)
+start_sound_tag::execute_state(sprite_instance* /* m */)
 {
        using globals::s_sound_handler;
 
+       //GNASH_REPORT_FUNCTION;
+
        if (s_sound_handler)
        {
                if (m_stop_playback)

Index: server/sound.h
===================================================================
RCS file: /sources/gnash/gnash/server/sound.h,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -b -r1.6 -r1.7
--- server/sound.h      21 Nov 2006 00:25:46 -0000      1.6
+++ server/sound.h      21 Feb 2007 08:17:08 -0000      1.7
@@ -59,7 +59,18 @@
                void read(stream* in, int tag_type,
                        movie_definition* m, const sound_sample_impl* sam);
 
-               void    execute(sprite_instance* m);
+               /// StartSound is a "state" tag.
+               void    execute_state(sprite_instance* m);
+
+               /// This implementation of 'execute' should likely
+               /// be the default one.
+               void execute(sprite_instance* m)
+               {
+                       execute_state(m);
+               }
+
+               /// TODO: provide execute_reverse ?
+               /// (for StartSound would StopSound and vice-versa)
        };
 
        /// SWF Tag SoundStreamBlock (19)