Re: [Gnash-commit] gnash ChangeLog server/character.cpp server/cha...

[Udo Giacomozzi]

Hello Sandro,

Wednesday, December 6, 2006, 1:48:51 PM, you wrote:
SS>         void clear_invalidated() {
SS>                 m_invalidated = false;    
SS> +               // Is it correct to set old bounds to null ?
SS> +               // Why are we doing so ?
SS>                 m_old_invalidated_bounds.set_null();
SS>         }


Yes, it's corrent. m_old_invalidated_bounds is used to keep track of
the character's position prior to any visual change.
For example, when you move a character horizontally, then
m_old_invalidated_bounds will contain the bounding rect prior to the
movement and get_invalidated_bounds() will internally get the bounding
rect of the new position. But since both positions need to be redrawn
both rects need to be unified.


   +----------------------------------+
   |.............        ooooooooooooo|
   |.           .        o           o|
   |.           .   ->   o           o|
   |.           .        o           o|
   |.............        ooooooooooooo|
   +----------------------------------+

   .... = old position
   oooo = new position
   ---- = combined invalidated rect (what's being re-rendered)
   

Udo