gnash-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-commit] gnash ChangeLog backend/sound_handler_sdl.cpp [releas


From: strk
Subject: Re: [Gnash-commit] gnash ChangeLog backend/sound_handler_sdl.cpp [release_0_7_2]
Date: Tue, 7 Nov 2006 00:57:02 +0100

On Mon, Nov 06, 2006 at 11:47:55PM +0000, Tomas Groth wrote:

> Modified files:
>       .              : ChangeLog 
>       backend        : sound_handler_sdl.cpp 
> 
> Log message:
>       Added some asserts, and some 0-index fixes.
> 

[...]

> +                                     // Test if we will get problems... 
> Should not happen...
> +                                     assert(sound->raw_position + 
> sound->raw_data_size-1 - sound->raw_position < sound->raw_data_size);
> +


Note: ( A + B - 1 - A < B ) == ( B - 1  < B ) == *always true*
... unless B is unsigned and B-1 overflows it ...

(there are three occurrences of such an assertion)

---strk;




reply via email to

[Prev in Thread] Current Thread [Next in Thread]