[Gnash-commit] gnash ChangeLog backend/render_handler_agg.cpp

[Udo Giacomozzi]

CVSROOT:        /cvsroot/gnash
Module name:    gnash
Changes by:     Udo Giacomozzi <udog>   06/11/06 08:14:13

Modified files:
        .              : ChangeLog 
        backend        : render_handler_agg.cpp 

Log message:
        Protected clear_framebuffer() against negative width and height 
arguments

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.1532&r2=1.1533
http://cvs.savannah.gnu.org/viewcvs/gnash/backend/render_handler_agg.cpp?cvsroot=gnash&r1=1.39&r2=1.40

Patches:
Index: ChangeLog
===================================================================
RCS file: /cvsroot/gnash/gnash/ChangeLog,v
retrieving revision 1.1532
retrieving revision 1.1533
diff -u -b -r1.1532 -r1.1533
--- ChangeLog   5 Nov 2006 23:10:43 -0000       1.1532
+++ ChangeLog   6 Nov 2006 08:14:13 -0000       1.1533
@@ -1,3 +1,8 @@
+2006-11-06 Udo Giacomozzi <address@hidden>
+
+       * backend/render_handler_agg.cpp: Protected clear_framebuffer() 
+       against negative width and height arguments
+
 2006-11-05  Rob Savoye  <address@hidden>
 
        * gui/gui.h: Add stuff for Emacs mode.

Index: backend/render_handler_agg.cpp
===================================================================
RCS file: /cvsroot/gnash/gnash/backend/render_handler_agg.cpp,v
retrieving revision 1.39
retrieving revision 1.40
diff -u -b -r1.39 -r1.40
--- backend/render_handler_agg.cpp      4 Nov 2006 12:34:55 -0000       1.39
+++ backend/render_handler_agg.cpp      6 Nov 2006 08:14:13 -0000       1.40
@@ -16,7 +16,7 @@
 
  
 
-/* $Id: render_handler_agg.cpp,v 1.39 2006/11/04 12:34:55 udog Exp $ */
+/* $Id: render_handler_agg.cpp,v 1.40 2006/11/06 08:14:13 udog Exp $ */
 
 // Original version by Udo Giacomozzi and Hannes Mayr, 
 // INDUNET GmbH (www.indunet.it)
@@ -519,10 +519,17 @@
        /// still correct, but slower. 
   /// This function clears only a certain portion of the screen, while /not/ 
   /// being notably slower for a fullscreen clear. 
-       void clear_framebuffer(unsigned int left, unsigned int top, 
-    unsigned int width, unsigned int height, agg::rgba8 color) {
+       void clear_framebuffer(int left, int top, int width, int height, 
agg::rgba8 color) {
     
-         if (!width) return;
+         if (width<1) {
+           log_msg("warning: clear_framebuffer() called with width=%d", width);
+      return;
+    }
+    
+         if (height<1) {
+           log_msg("warning: clear_framebuffer() called with height=%d", 
height);
+      return;
+    }
          
          unsigned int y;
          const unsigned int max_y = top+height; // to be exact, it's one off 
the max.