[Gnash-commit] gnash ChangeLog server/parser/movie_def_impl.cpp

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  06/10/24 07:32:00

Modified files:
        .              : ChangeLog 
        server/parser  : movie_def_impl.cpp 

Log message:
        * server/parser/movie_def_impl.cpp (create_instance): minor cleanups.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.1372&r2=1.1373
http://cvs.savannah.gnu.org/viewcvs/gnash/server/parser/movie_def_impl.cpp?cvsroot=gnash&r1=1.28&r2=1.29

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.1372
retrieving revision 1.1373
diff -u -b -r1.1372 -r1.1373
--- ChangeLog   23 Oct 2006 23:01:09 -0000      1.1372
+++ ChangeLog   24 Oct 2006 07:32:00 -0000      1.1373
@@ -1,3 +1,7 @@
+2006-10-24 Sandro Santilli <address@hidden>
+
+       * server/parser/movie_def_impl.cpp (create_instance): minor cleanups.
+
 2006-10-24 Markus Gothe <address@hidden>
 
        * configure.ac: Fixed finding correct X11-ABI and X11-lib-path on IRIX.

Index: server/parser/movie_def_impl.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/parser/movie_def_impl.cpp,v
retrieving revision 1.28
retrieving revision 1.29
diff -u -b -r1.28 -r1.29
--- server/parser/movie_def_impl.cpp    20 Oct 2006 17:01:03 -0000      1.28
+++ server/parser/movie_def_impl.cpp    24 Oct 2006 07:32:00 -0000      1.29
@@ -750,18 +750,16 @@
 movie_interface*
 movie_def_impl::create_instance()
 {
+       @@ Shouldn't we return a movie_instance instead ?
+       @@ and leave movie_root creation to the caller ..
+
     movie_root*        m = new movie_root(this);
-    assert(m);
 
-    sprite_instance* root_movie = new movie_instance(this, m, NULL);
-    assert(root_movie);
+    movie_instance* root_movie = new movie_instance(this, m, NULL);
 
     root_movie->set_name("_root");
     m->set_root_movie(root_movie);
 
-    // @@ somewhere in here I *might* add _url variable
-    // (or is it a member?)
-
     m->add_ref();
 
        // I don't think we should be executing actions