[Gnash-commit] gnash ChangeLog server/parser/edit_text_charact...

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  06/09/21 09:09:18

Modified files:
        .              : ChangeLog 
        server/parser  : edit_text_character_def.cpp 

Log message:
                * server/parser/edit_text_character_def.cpp: added comment
                  about why we're doing the wrong thing with VariableName
                  (related to bug#17806)

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.887&r2=1.888
http://cvs.savannah.gnu.org/viewcvs/gnash/server/parser/edit_text_character_def.cpp?cvsroot=gnash&r1=1.3&r2=1.4

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.887
retrieving revision 1.888
diff -u -b -r1.887 -r1.888
--- ChangeLog   21 Sep 2006 09:05:16 -0000      1.887
+++ ChangeLog   21 Sep 2006 09:09:18 -0000      1.888
@@ -1,3 +1,9 @@
+2006-09-21 Sandro Santilli  <address@hidden>
+
+       * server/parser/edit_text_character_def.cpp: added comment
+         about why we're doing the wrong thing with VariableName
+         (related to bug#17806)
+
 2006-09-21 Deanna Phillips <deanna>
 
        * plugin/Makefile.am: removed unneeded explicit copy of shared

Index: server/parser/edit_text_character_def.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/parser/edit_text_character_def.cpp,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -b -r1.3 -r1.4
--- server/parser/edit_text_character_def.cpp   20 Sep 2006 14:18:50 -0000      
1.3
+++ server/parser/edit_text_character_def.cpp   21 Sep 2006 09:09:18 -0000      
1.4
@@ -117,6 +117,25 @@
        get_font();
        edit_text_character* ch = new edit_text_character(parent, this, id);
 
+       // This gives an "instance name" to the TextField, but
+       // it is not really what we need.
+       //
+       // First of all the VariableName ("m_default_name") is
+       // NOT the default name of an instance, rather it is
+       // a variable associated with it and can contain path
+       // information (ie. we can associate a variable in a different
+       // timeline)
+       //
+       // We actually need to set that variable to an object which
+       // is a TextField dinamic variable. The object should take
+       // care of updating this TextField text when assigned to
+       // and to retrive this TextField text when extracted value from.
+       //
+       // The DefineEditTextVariableNameTest.swf file under 
+       // testsuite/misc-ming.all gives an idea of the problem
+       // (in particular it shows a case in which VariableName is
+       // outside of TextField timeline/scope)
+       //
        ch->set_name(m_default_name.c_str());
 
        return ch;