[Gnash-commit] gnash ChangeLog server/swf/ASHandlers.cpp

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  06/07/01 01:34:03

Modified files:
        .              : ChangeLog 
        server/swf     : ASHandlers.cpp 

Log message:
                * server/swf/ASHandlers.cpp (ActionGetUrl): fixed read
                of 'target' parameter (action still not fully implemented,
                see bug #16435).

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.452&r2=1.453
http://cvs.savannah.gnu.org/viewcvs/gnash/server/swf/ASHandlers.cpp?cvsroot=gnash&r1=1.25&r2=1.26

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.452
retrieving revision 1.453
diff -u -b -r1.452 -r1.453
--- ChangeLog   1 Jul 2006 00:43:58 -0000       1.452
+++ ChangeLog   1 Jul 2006 01:34:03 -0000       1.453
@@ -1,5 +1,8 @@
 2006-06-30 Sandro Santilli <address@hidden>
 
+       * server/swf/ASHandlers.cpp (ActionGetUrl): fixed read
+       of 'target' parameter (action still not fully implemented,
+       see bug #16435).
        * server/dlist.cpp: (advance): keep characters alive
        during advancement of them, in case they get removed
        from the DisplayList (see bug #16815).

Index: server/swf/ASHandlers.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/swf/ASHandlers.cpp,v
retrieving revision 1.25
retrieving revision 1.26
diff -u -b -r1.25 -r1.26
--- server/swf/ASHandlers.cpp   1 Jul 2006 00:30:02 -0000       1.25
+++ server/swf/ASHandlers.cpp   1 Jul 2006 01:34:03 -0000       1.26
@@ -540,9 +540,15 @@
        // handler, if any.
                  
        // Two strings as args.
+       // TODO: make sure the NULL terminations are there
+       // we could implement a safe_read_string(pc, maxlen)
+       // and use tag length as maxlen
+       size_t tag_length = code.read_int16(pc+1);
        const char* url = code.read_string(pc+3);
-       //size_t url_len = strlen(url);
-       const char* target = code.read_string(pc+3);
+       size_t url_len = strlen(url)+1;
+       const char* target = code.read_string(pc+3+url_len);
+
+       log_action("GetUrl: target=%s url=%s", target, url);
                  
        // If the url starts with an "http" or "https",
        // then we want to load it into a web browser.