[gmediaserver-devel] about SSDP_PAUSE

[Nektarios K. Papadopoulos]

Hi,

while testing an older version of gmediaserver (0.9.0) and the newest 
version of libupnp fork (1.4.0 http://www.libupnp.org) I realized the 
missing SSDP_PAUSE issue that you have already worked in later versions 
of gmediaserver revision 1.2 of src/upnp.c in CVS. Diff attached just 
for context.

SSDP_PAUSE is meant to be an internal configuration option for the 
library. It is used as the interval in *milliseconds* between identical 
SSDP advertisement and search packets. "Identical" does not refer to the 
resent advertisement after expiration. It refers to a single 
advertisement sent more than one times to the network in order to cope 
with UDP unreliability.

I suggest you just define your own constant for the device advertisement 
expiration interval.

Best regards,
Nektarios

Index: src/upnp.c
===================================================================
RCS file: /sources/gmediaserver/gmediaserver/src/upnp.c,v
retrieving revision 1.3
diff -u -r1.3 upnp.c
--- src/upnp.c  8 Apr 2006 15:17:53 -0000       1.3
+++ src/upnp.c  7 Jul 2006 10:50:48 -0000
@@ -38,15 +38,8 @@
 #include "gmediaserver.h"
 #include "schemas/MediaServer.h"
 
-/* libupnp 1.2.x has SSDP_PAUSE, but not 1.3.x
- * Perhaps this kludge should be moved somewhere else.
- */
-#ifndef SSDP_PAUSE
-#define SSDP_PAUSE 100
-#endif
-
 char *friendly_name = NULL;
-int ssdp_expire_time = SSDP_PAUSE;
+int ssdp_expire_time = 100;
 static UpnpDevice_Handle device;
 static char device_udn[42]; /* uuid:xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx + 
null-byte */