[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Glibc-bsd-hackers] Re: [PATCH] GNU/k*BSD support (with ChangeLog) for g
From: |
Robert Millan |
Subject: |
[Glibc-bsd-hackers] Re: [PATCH] GNU/k*BSD support (with ChangeLog) for gcc |
Date: |
Tue, 1 Jun 2004 15:42:56 +0200 |
User-agent: |
Mutt/1.5.6i |
On Tue, Jun 01, 2004 at 02:07:30AM -0700, Jim Wilson wrote:
>
> The patch looks pretty good to me.
>
> I think the gcc/config/linux.h change is unnecessary, since there should
> never be anything included before config/linux.h that will override
> LINUX_TARGET_OS_CPP_BUILTINS. The only files that override will be
> included after, and use undef.
I assume the same applies to config/i386/linux.h. I'm sending a revised
patch that fixes both.
> Otherwise, I don't see any problems. That one problem is simple enough
> that I could just fix it myself before checking it in. I don't want to
> check in a patch before I leave on a trip though, so I will take care of
> this when I get back unless someone else beats me to it.
Since this patch is quite old (2+1/2 months) for being a tiny portability fix
I'll be happy if anyone commits the revised version I'm just attaching in the
following days.
(Patch attached. ChangeLog in patch header)
--
Robert Millan
"[..] but the delight and pride of Aule is in the deed of making, and in the
thing made, and neither in possession nor in his own mastery; wherefore he
gives and hoards not, and is free from care, passing ever on to some new work."
-- J.R.R.T., Ainulindale (Silmarillion)
kbsd-gnu.diff
Description: Text document