[Gforge-devel] address@hidden: patch]

[Ryan T. Sammartino]

It seems that php 4.3 sets $uploaded_notes and $uploaded_changes to ""
when no file is attached, while php < 4.3 sets it to "none".

OK to commit the patch below?

----- Forwarded message from "Sammartino, Ryan" <address@hidden> -----

From: "Sammartino, Ryan" <address@hidden>
Subject: patch
Date: Wed, 22 Jan 2003 08:54:45 -0800
Message-id: <address@hidden>
To: address@hidden

Index: editrelease.php
===================================================================
RCS file: /cvsroot/gforge/gforge/www/project/admin/editrelease.php,v
retrieving revision 1.5
diff -u -r1.5 editrelease.php
--- editrelease.php     19 Jan 2003 01:10:10 -0000      1.5
+++ editrelease.php     22 Jan 2003 16:54:24 -0000
@@ -66,7 +66,7 @@
        $exec_changes = true;
 
        // Check for uploaded release notes
-       if ($uploaded_notes != "") {
+       if ($uploaded_notes != "" && $uploaded_notes != "none") {
                if (!is_uploaded_file($uploaded_notes)) {
                        exit_error('Error','Attempted File Upload Attack');
                }
@@ -80,7 +80,7 @@
        }
 
        // Check for uplaoded change logs
-       if ($uploaded_changes != "") {
+       if ($uploaded_changes != "" && $uploaded_changes != "none") {
                if (!is_uploaded_file($uploaded_changes)) {
                        exit_error('Error','Attempted File Upload Attack');
                }


----- End forwarded message -----

-- 
Ryan T. Sammartino
http://members.shaw.ca/ryants/
Antonym, n.:
        The opposite of the word you're trying to think of.