[Gforge-commits] gforge/common/include Group.class,1.52,1.53

[cbayle]

Update of /cvsroot/gforge/gforge/common/include
In directory db.perdue.net:/tmp/cvs-serv3490/common/include

Modified Files:
        Group.class 
Log Message:
Make better coding/code cleaning


Index: Group.class
===================================================================
RCS file: /cvsroot/gforge/gforge/common/include/Group.class,v
retrieving revision 1.52
retrieving revision 1.53
diff -u -d -r1.52 -r1.53
--- Group.class 22 Jul 2004 23:40:03 -0000      1.52
+++ Group.class 23 Jul 2004 10:51:53 -0000      1.53
@@ -895,12 +895,13 @@
                $booleanparam = $booleanparam ? 1 : 0 ;
                $sql = "UPDATE groups SET enable_anonscm = $booleanparam WHERE 
group_id = ".$this->getID() ;
                $res = db_query($sql);
-               if ($res) $this->data_array['enable_anonscm']=$booleanparam;
-               //if (!$this->fetchData($this->getID())) {
-               //      db_rollback();
-               //      return false;
-               //}
-               db_commit () ;
+               if ($res) {
+                       $this->data_array['enable_anonscm']=$booleanparam;
+                       db_commit () ;
+               } else {
+                       db_rollback ();
+                       return false;
+               }
        }
 
        /**
@@ -921,12 +922,13 @@
                $booleanparam = $booleanparam ? 1 : 0 ;
                $sql = "UPDATE groups SET enable_pserver = $booleanparam WHERE 
group_id = ".$this->getID() ;
                $res = db_query($sql);
-               if ($res) $this->data_array['enable_pserver']=$booleanparam;
-               //if (!$this->fetchData($this->getID())) {
-               //      db_rollback();
-               //      return false;
-               //}
-               db_commit () ;
+               if ($res) {
+                       $this->data_array['enable_pserver']=$booleanparam;
+                       db_commit () ;
+               } else {
+                       db_rollback();
+                       return false;
+               }
        }
 
        /**