Re: [Getfem-commits] please merge branch code_cleanup_to_pep8

[Tetsuo Koyama]

Yves and Konstantinos

Sorry for my late reply. Thank you for your comment.
I have found that applying pep8 strictly in this project is not good.
Because the purpose of the python in this project is for scripting not
for source.
I withdraw the branch. Can you delete this?
Thank you for taking part in the discussion.

Best regards Tetsuo

> Dear Tetsuo,
>
> I agree with Kostas on this subject. On one side the format is quite pleasant 
> and quite legible on some points. On the other hand, some passages of the 
> formatted code like
>
>        md.add_basic_contact_brick(
>            "u",
>            "lambda_n",
>            "lambda_t",
>            "r",
>            BN,
>            BT,
>            "friction_coeff",
>            "ngap",
>            "alpha",
>            1,
>        )
>
> with one argument on each line is horrible for me. If the format is too 
> sparse this is not easy to read the code for me. Additionnaly, some comments 
> have been misaligned which is really less readable.
>
> Best regards,
>
> Yves

2019年6月25日(火) 20:03 Tetsuo Koyama <address@hidden>:
>
> Dear Kostas
>
> Thank you for your feedback.
> > feel insecure with automatic formating tools
> That’s a good point. It may be too early to merge it to master.
> I should check script one by one.
>
> Any other comment?
>
> BR
> Tetsuo
>
> 2019年6月25日(火) 19:39 Konstantinos Poulios <address@hidden>:
> >
> > Hi, I am not sure about this. I like standardized strict code formatting 
> > but I personally feel insecure with automatic formating tools.
> >
> > BR
> > Kostas
> >
> > On Fri, Jun 21, 2019 at 4:19 PM Tetsuo Koyama <address@hidden> wrote:
> >>
> >> Dear GetFEM++ project
> >>
> >> Hello. I formatted python script to pep8 by using
> >> black(https://github.com/python/black).
> >>
> >> Python developers are increasingly using black. I think that by
> >> defining the format of the script in the tool, we are freed from
> >> meaningless discussions about the format. I welcome any comments on
> >> this change.
> >>
> >> Thank you for your reading.
> >>