[Gcl-devel] Re: windows-only read patch (was: error in ./configure when building gcl 2.6.7 onUbuntu)

[Camm Maguire]

Greetings!

"Bill Page" <address@hidden> writes:

> Camm,
> 
> What are the symptoms of this change? What problem is it
> intended to correct? How can I test it? Is it sufficient
> if I can build Axiom on windows after this change?
> 

The code is intended to fix read-char-no-hang, which had been broken
for a long time.  This caused Mike Thomas some problem of which I do
not know the details, hence his ifdef patch with the comment:

revision 1.14.4.1.2.2.2.4.6.1.6.1.4.3
date: 2006-06-15 22:26:22 -0400;  author: mjthomas;  state: Exp;  lines: +2 -1
Band aid fix to stop build failure on Windows.
----------------------------

Vadim found the discrepancy in testing maxima:

http://www.mail-archive.com/address@hidden/msg01408.html

Ideally, I'd like to know that reverting the patch works for both of
you.  I'd really be pleased if someone could try acl2 as well.

Alas, due to email chaos, I seem to be disconnected from Vadim.

Take care,


> Regards,
> Bill Page.
> 
> > -----Original Message-----
> > From: Camm Maguire [mailto:address@hidden 
> > Sent: January 11, 2007 10:51 AM
> > To: Bill Page
> > Cc: address@hidden; address@hidden
> > Subject: Re: [Gcl-devel] Re: error in ./configure when 
> > building gcl 2.6.7 onUbuntu
> > 
> > 
> > Greetings, and thanks so much!
> > 
> > Could you please try reverting:
> > 
> > cvs -z9 -q diff -u -r 1.14.4.1.2.2.2.4.6.1.6.1.4.2 -r 
> > 1.14.4.1.2.2.2.4.6.1.6.1.4.3 read.d
> > Index: read.d
> > ===================================================================
> > RCS file: /cvsroot/gcl/gcl/o/read.d,v
> > retrieving revision 1.14.4.1.2.2.2.4.6.1.6.1.4.2
> > retrieving revision 1.14.4.1.2.2.2.4.6.1.6.1.4.3
> > diff -u -r1.14.4.1.2.2.2.4.6.1.6.1.4.2 -r1.14.4.1.2.2.2.4.6.1.6.1.4.3
> > --- read.d  7 Jun 2006 15:09:38 -0000       
> > 1.14.4.1.2.2.2.4.6.1.6.1.4.2
> > +++ read.d  16 Jun 2006 02:26:22 -0000      
> > 1.14.4.1.2.2.2.4.6.1.6.1.4.3
> > @@ -256,6 +256,7 @@
> >  
> >     x = read_object(in);
> >     vs_push(x);
> > +#ifndef _WIN32
> >     while (listen_stream(in)) {
> >       object c=read_char(in);
> >       if (cat(c)!=cat_whitespace) {
> > @@ -263,7 +264,7 @@
> >         break;
> >       }
> >     }
> > -
> > +#endif
> >     if (sharp_eq_context_max > 0)
> >             x = vs_head = patch_sharp(x);
> >  
> > Take care,
> > 
> > 
> > 
> > "Bill Page" <address@hidden> writes:
> > 
> > > Camm,
> > > 
> > > On January 10, 2007 11:12 AM you wrote:
> > > > ... 
> > > > export CVSROOT=:pserver:address@hidden:/sources/gcl
> > > > cvs -z9 -q co -d gcl-2.6.8pre -r Version_2_6_8pre
> > > > 
> > > > This is way past due for release.  I am only waiting on a 
> > volunteer
> > > > to test a windows-only read patch -- alas our heroic windows
> > > > volunteer has resigned.  If anyone here can help please let me
> > > > know.
> > > > ...
> > > 
> > > Both Gaby and I have successfully built Axiom on Windows from a
> > > recent version of gcl-2.6.8pre. What is required in order to test
> > > this "windows-only read patch"?
> > > 
> > > Regards,
> > > Bill Page.
> > > 
> > > 
> > > 
> > > 
> > > 
> > 
> > -- 
> > Camm Maguire                                                
> > address@hidden
> > ==============================================================
> > ============
> > "The earth is but one country, and mankind its citizens."  -- 
> >  Baha'u'llah
> > 
> > 
> 
> 
> 
> 
> 

-- 
Camm Maguire                                            address@hidden
==========================================================================
"The earth is but one country, and mankind its citizens."  --  Baha'u'llah