Re: [Gcl-devel] (ANSI) Added some string-related tests

[Paul F. Dietz]

Comments on the tests:

> MAP-STRING.31, MAP-STRING.32,

MAP where the type argument is of the form (simple-array character ???).

> STRUCTURE-1-13,

CLASS-OF is called on a structure object (this should be legal since
every structure type is also a class.)

> STRUCTURE-1-14,

Structures should be elements of the type STRUCTURE-OBJECT.

>    STRUCTURE-1-15

Structure types should be subtypes of STRUCTURE-OBJECT.

> BOOLEAN-TYPE-1, BOOLEAN-TYPE-2, BOOLEAN-TYPE-3

NIL and T should be in the type BOOLEAN, but they are not.

>    TYPES-3,

The spec specifiers a large number of subtypep relationships between
builtin type symbols.  This test checks them, returning the number that
aren't correct.  It should return 0, but there are 56 pairs that
fail.

> TYPES-5

SIMPLE-BASE-STRING should be a subtype of SEQUENCE.  It's not.

> TYPES-6,

Checks that primitive type symbols in CL that are not SEQUENCE, CONS, LIST, or T
are subtypes of ATOM (ATOM, please recall, is everything that isn't a CONS.)

The spec says that SUBTYPEP must succeed if its two arguments are builtin type
symbols, btw.  Allegro CL gets this very wrong; last I checked CMU CL did as
well.

> TYPES-8,

Similar to TYPES-6.

> TYPES-9

Checks SUBTYPEP for transititivity on the builtin type symbols.

> TYPES-9A, 

Checks that TYPEP is consistent with SUBTYPEP on a large collection
of builtin type symbols and a universe of various kinds of lisp values.

>    READ-SYMBOL-8

is a bad test.  I will remove it.

> READ-SYMBOL-10,

Lack of support for the :READABLY keyword in WRITE.

> CHAR.3, CHAR.4,

Tests were busted; fixed.

> CHAR.6, CHAR.7, 

MAKE-STRING should take an :ELEMENT-TYPE keyword argument; it doesn't.

>    CHAR.8

Test was busted; fixed but still fails.  This is a subtle point: CHAR must
ignore the fill-pointer in an array that has one (see the spec page for CHAR).

> CHAR.9, CHAR.10, SCHAR.4, SCHAR.5, SCHAR.6, SCHAR.7,

MAKE-STRING needs to take :ELEMENT-TYPE.

>    STRING.7, 

The function STRING must always either return a string *or* signal
a type-error (at safe calls).

> BASE-STRING.1,  BASE-STRING.2, BASE-STRING.3, BASE-STRING.4,

BASE-STRING should be a subtype of STRING, VECTOR, ARRAY, and SEQUENCE.

> SIMPLE-STRING.5

SIMPLE-STRING should be a subtype of SEQUENCE.

> SIMPLE-BASE-STRING.1, SIMPLE-BASE-STRING.2, SIMPLE-BASE-STRING.3, 
SIMPLE-BASE-STRING.4,
>    SIMPLE-BASE-STRING.5, SIMPLE-BASE-STRING.6, SIMPLE-BASE-STRING.7,

SIMPLE-BASE-STRING should be a subtype of string, simple-string, base-string, 
vector,
simple-vector, simple-array, array, and sequence.


>  SIMPLE-STRING-P.5, STRINGP.4

(MAKE-ARRAY 4 :ELEMENT-TYPE 'BASE-CHAR ...) is not being recognized as a simple 
string
or a string.

        Paul