[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[SCM] gawk branch, gawk-5.1-stable, updated. gawk-4.1.0-4315-gf597ee8
From: |
Arnold Robbins |
Subject: |
[SCM] gawk branch, gawk-5.1-stable, updated. gawk-4.1.0-4315-gf597ee8 |
Date: |
Sun, 26 Sep 2021 13:56:41 -0400 (EDT) |
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "gawk".
The branch, gawk-5.1-stable has been updated
via f597ee8f9ac128f88f85639ffbce6d7248776f75 (commit)
from 8d8cd2e6e75399b9f8b1e0517dcfdb1a80cd1e3f (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://git.sv.gnu.org/cgit/gawk.git/commit/?id=f597ee8f9ac128f88f85639ffbce6d7248776f75
commit f597ee8f9ac128f88f85639ffbce6d7248776f75
Author: Arnold D. Robbins <arnold@skeeve.com>
Date: Sun Sep 26 20:56:19 2021 +0300
Update FIXME and comments and builtin.c:do_mktime.
diff --git a/ChangeLog b/ChangeLog
index 3c69485..2fa6888 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2021-09-26 Arnold D. Robbins <arnold@skeeve.com>
+
+ * builtin.c (do_mktime): Update that ISO 8601 does not allow
+ hours > 23. Thanks to Nethox <nethox+awk@gmail.com> for the info.
+
2021-09-23 Arnold D. Robbins <arnold@skeeve.com>
* gawkapi.h: Some clean-up of comments in the header file.
diff --git a/builtin.c b/builtin.c
index cf0c98e..d7ba82c 100644
--- a/builtin.c
+++ b/builtin.c
@@ -2121,10 +2121,12 @@ do_mktime(int nargs)
& hour, & minute, & second,
& dst);
+ // 9/2021: I've been told that according to the ISO 8601-1:2019 spec,
+ // hour cannot be 24. So the check for hour > 23 is valid.
if ( do_lint /* Ready? Set! Go: */
&& ( (second < 0 || second > 60)
|| (minute < 0 || minute > 59)
- || (hour < 0 || hour > 23) /* FIXME ISO 8601 allows 24 ? */
+ || (hour < 0 || hour > 23)
|| (day < 1 || day > 31)
|| (month < 1 || month > 12) ))
lintwarn(_("mktime: at least one of the values is out
of the default range"));
-----------------------------------------------------------------------
Summary of changes:
ChangeLog | 5 +++++
builtin.c | 4 +++-
2 files changed, 8 insertions(+), 1 deletion(-)
hooks/post-receive
--
gawk
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [SCM] gawk branch, gawk-5.1-stable, updated. gawk-4.1.0-4315-gf597ee8,
Arnold Robbins <=