Re: Check return of function

[Werner LEMBERG]

>> Today the code is like this:
>>
>>     error = FT_New_Size( t42face->ttf_face, &ttsize );
>>     t42size->ttsize = ttsize;
>>     FT_Activate_Size( ttsize );
>>
>>  My initial suggestion was:
>>
>>     error = FT_New_Size( t42face->ttf_face, &ttsize );
>>     if(error)
>>         return error;
>>     t42size->ttsize = ttsize;
>>     FT_Activate_Size( ttsize );
>>
>> However, I observed that if ttsize is NULL, FT_Activate_Size
>> function will throw an exception.  Great In this case, what do you
>> think about this another change?
>>
>>     error = FT_New_Size( t42face->ttf_face, &ttsize );
>>     if(!error)
>>         t42size->ttsize = ttsize;
>>     FT_Activate_Size( ttsize );

I agree with Alexei that the change you suggest is not necessary.
Maybe I'm wrong, however: do you have a font that exhibits a problem
with the original code?

Note that FreeType gets tested continuously with a fuzzer, and there
wasn't any report to the code in question.


    Werner