[Git][freetype/freetype][master] [bdf] Fix use of uninitialized value.

[Werner Lemberg (@wl)]

Werner Lemberg pushed to branch master at FreeType / FreeType

Commits:

• bad92be9
  by Ben Wagner at 2021-12-09T17:07:58-05:00

  [bdf] Fix use of uninitialized value.
  
  In _bdf_readstream if the data contained no newline then the buffer
  would continue to grow and uninitialized data read until either the
  uninitialized data contained a newline or the buffer reached its
  maxiumum size. The assumption was that the line was always too long and
  the buffer had been filled, however this case can also happen when there
  is not enough data to fill the buffer.
  
  Correct this by properly setting the cursor to the end of the available
  data, which may be different from the end of the buffer. This may still
  result in one extra allocation, but only on malformed fonts.
  
  * src/bdf/bdflib.c (_bfd_readstream): Correctly update cursor. Remove
  unread set of `avail`.
  
  Bug: https://lists.nongnu.org/archive/html/freetype-devel/2021-12/msg00001.html
  

1 changed file:

• src/bdf/bdflib.c

Changes:

src/bdf/bdflib.c

---

...	...	@@ -613,7 +613,7 @@
613	613	if ( FT_QREALLOC( buf, buf_size, new_size ) )
614	614	goto Exit;
615	615
616		- cursor = (ptrdiff_t)buf_size;
	616	+ cursor = avail;
617	617	buf_size = new_size;
618	618	}
619	619	else
...	...	@@ -623,7 +623,6 @@
623	623	FT_MEM_MOVE( buf, buf + start, bytes );
624	624
625	625	cursor = bytes;
626		- avail -= bytes;
627	626	start = 0;
628	627	}
629	628	refill = 1;

—
View it on GitLab.
You're receiving this email because of your account on gitlab.freedesktop.org. If you'd like to receive fewer emails, you can adjust your notification settings.