[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[freetype2] master 4166c45 1/2: [base] Fix thinko in previous commit.
From: |
Werner LEMBERG |
Subject: |
[freetype2] master 4166c45 1/2: [base] Fix thinko in previous commit. |
Date: |
Tue, 23 Apr 2019 00:54:33 -0400 (EDT) |
branch: master
commit 4166c453601e856fa61e8994085f240d8771e980
Author: Werner Lemberg <address@hidden>
Commit: Werner Lemberg <address@hidden>
[base] Fix thinko in previous commit.
* src/base/ftbitmap.c (FT_Bitmap_Blend): Check final width, not
target pitch.
Problem reported by Sender Ghost <address@hidden>.
---
ChangeLog | 9 +++++++++
src/base/ftbitmap.c | 20 ++++++++++----------
2 files changed, 19 insertions(+), 10 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 78b82c9..92a2556 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2019-04-23 Werner Lemberg <address@hidden>
+
+ [base] Fix thinko in previous commit.
+
+ * src/base/ftbitmap.c (FT_Bitmap_Blend): Check final width, not
+ target pitch.
+
+ Problem reported by Sender Ghost <address@hidden>.
+
2019-04-22 Werner Lemberg <address@hidden>
* src/base/ftbitmap.c (FT_Bitmap_Blend): Check target pitch.
diff --git a/src/base/ftbitmap.c b/src/base/ftbitmap.c
index 7e5e92d..0e0a76f 100644
--- a/src/base/ftbitmap.c
+++ b/src/base/ftbitmap.c
@@ -922,12 +922,18 @@
else
FT_TRACE5(( " target bitmap: empty\n" ));
- FT_TRACE5(( " final bitmap: (%d, %d) -- (%d, %d); %d x %d\n",
- final_llx / 64, final_lly / 64,
- final_urx / 64, final_ury / 64,
- final_width, final_rows ));
+ if ( final_width && final_rows )
+ FT_TRACE5(( " final bitmap: (%d, %d) -- (%d, %d); %d x %d\n",
+ final_llx / 64, final_lly / 64,
+ final_urx / 64, final_ury / 64,
+ final_width, final_rows ));
+ else
+ FT_TRACE5(( " final bitmap: empty\n" ));
#endif /* FT_DEBUG_LEVEL_TRACE */
+ if ( !( final_width && final_rows ) )
+ return FT_Err_Ok; /* nothing to do */
+
/* for blending, set offset vector of final bitmap */
/* temporarily to (0,0) */
source_llx -= final_llx;
@@ -971,12 +977,6 @@
pitch = target->pitch;
- if ( !pitch )
- {
- FT_TRACE5(( "FT_Blend_Bitmap:"
- " zero target bitmap pitch is invalid\n" ));
- return FT_THROW( Invalid_Argument );
- }
if ( pitch < 0 )
pitch = -pitch;
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [freetype2] master 4166c45 1/2: [base] Fix thinko in previous commit.,
Werner LEMBERG <=