Re: [Freeipmi-devel] Bug when querying bridged sensors

[Albert Chu]

Hi Marc,

Thanks for the patch.  As far as I can tell, you are absolutely right. 
I'm not sure how this code even worked before, although I suspect many
IPMI implementations just automatically sent bridge requests to the
right place reqardless of the LUN.

I have this queued up for a fix in 1.6.2.  I see your patch was against
FreeIPMI 1.5.7.  Do you have a need for me to release a 1.5.8 at some
point in the future?

Al

On Fri, 2018-02-16 at 11:58 +0000, GIRARD, MARC wrote:
> Hi FreeIPMI Team,
>  
> We experiment a bug when querying bridged sensors of a Bull GPU
> Blade.
>  
> This bug can be solved with the following patch :
>  
> diff -pur freeipmi-1.5.7.orig/libfreeipmi/api/ipmi-lan-session-
> common.c freeipmi-1.5.7/libfreeipmi/api/ipmi-lan-session-common.c
> --- freeipmi-1.5.7.orig/libfreeipmi/api/ipmi-lan-session-
> common.c       2017-08-16 20:28:20.000000000 +0200
> +++ freeipmi-1.5.7/libfreeipmi/api/ipmi-lan-session-common.c    2018-
> 02-16 12:34:54.369033904 +0100
> @@ -1222,7 +1222,7 @@ _ipmi_cmd_send_ipmb (ipmi_ctx_t ctx, fii
>                           ctx->target.net_fn,
>                           ctx->target.lun,
>                           IPMI_SLAVE_ADDRESS_BMC,
> -                         IPMI_BMC_IPMB_LUN_SMS_MSG_LUN,
> +                         IPMI_BMC_IPMB_LUN_BMC ,
>                           ctx->io.outofband.rq_seq,
>                           obj_ipmb_msg_hdr_rq) < 0)
>      {
>  
> (and probably with identical patch in kcs and ssif interface)
>  
> According to the chapter 7.4 of IPMI specifications, it seems that
> IPMI_BMC_IPMB_LUN_SMS_MSG_LUN (0x02) are used by devices sending
> request to system management software, so I suspect a bug concerning
> all platforms.
>  
> Thank you for your comments.
>  
> (I apologize for my English)
>  
> Regards
> 
> Marc Girard
> Power Efficiency Team
> address@hidden
> https://eu.yourcircuit.com/#/email/address@hidden
> Bull, An Atos company (www.bull.com)
> _______________________________________________
> Freeipmi-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/freeipmi-devel
-- 
Albert Chu
address@hidden
Computer Scientist
High Performance Systems Division
Lawrence Livermore National Laboratory