[Freeipmi-devel] [bug #41903] interpret/ipmi-interpret.c: 3 * leap before look ?

[David Binderman]

URL:
  <http://savannah.gnu.org/bugs/?41903>

                 Summary: interpret/ipmi-interpret.c: 3 * leap before look ?
                 Project: GNU FreeIPMI
            Submitted by: dcb314
            Submitted on: Wed 19 Mar 2014 08:37:48 GMT
                Category: None
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
        Operating System: None

    _______________________________________________________

Details:

1.

[interpret/ipmi-interpret.c:513]: (style) Array index 'i' is used before
limits check.

Source code is

  while (sel_config[i]
         && i < offset_from_event_reading_type_code
         && i < IPMI_INTERPRET_MAX_SENSOR_AND_EVENT_OFFSET)

Maybe 

  while (i < offset_from_event_reading_type_code
         && i < IPMI_INTERPRET_MAX_SENSOR_AND_EVENT_OFFSET
         && sel_config[i])

might be better code.

2.

[interpret/ipmi-interpret.c:1028]: (style) Array index 'i' is used before
limits check.

3.

[interpret/ipmi-interpret.c:1131]: (style) Array index 'i' is used before
limits check.

Duplicates.








    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?41903>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/