[Freeipmi-devel] Re: ipmi-sensors abends when configuration file not specified at all

[Albert Chu]

Hi Dan,

This should already be handled.  What version of FreeIPMI are you
running?  Perhaps your freeipmi.conf has some typo in it that triggers a
different bug?

Al

On Sun, 2010-08-15 at 11:23 -0700, Dan Lukes wrote:
> Hi.
> 
> I hit the bug in the
> 
> ipmi-sensors/src/ipmi-sensors-argp.c
> 
> In the case the configuration file is not specified at all, the
> 
> cmd_args->common.config_file == NULL
> 
> Such situation is not handled correctly, the NULL is dereferenced and 
> program abends.
> 
> I suggest not to call  config_file_parse() at all, when configration 
> doesn't exist, e.g.:
> 
> if (config_file_parse (cmd_args->common.config_file,
> 
> should be changed to
> 
> if (cmd_args->common.config_file != NULL && config_file_parse 
> (cmd_args->common.config_file,
> 
> I tried it on my system and it helped.
> 
> As alternative, such case can be handled inside of config_file_parse() 
> function.
> 
> Hope it help.
> 
> Dan
> 
-- 
Albert Chu
address@hidden
Computer Scientist
High Performance Systems Division
Lawrence Livermore National Laboratory