Re: [Freeipmi-devel] bmc-info bug

[Al Chu]

Looking at section 6.4 in the spec, I guess the == to channel_info_list
[i].protocol_type was forgotten.  I'll add that.

Al

On Tue, 2007-01-09 at 09:41 -0800, Al Chu wrote:
>       if (IPMI_CHANNEL_PROTOCOL_TYPE_IS_RESERVED(channel_info_list
> [i].protocol_type))
>         printf ("    Protocol Type: %s\n", "Reserved");
>       else if (IPMI_CHANNEL_PROTOCOL_TYPE_IPMB)
>         printf ("    Protocol Type: %s\n", "IPMB-1.0");
>       else if (IPMI_CHANNEL_PROTOCOL_TYPE_ICMB_10)
>         printf ("    Protocol Type: %s\n", "ICMB-1.0");
>       else if (IPMI_CHANNEL_PROTOCOL_TYPE_SMBUS_1X_2X)
>         printf ("    Protocol Type: %s\n", "IPMI-SMBus");
>       else if (IPMI_CHANNEL_PROTOCOL_TYPE_KCS)
>         printf ("    Protocol Type: %s\n", "KCS");
>       else if (IPMI_CHANNEL_PROTOCOL_TYPE_SMIC)
>         printf ("    Protocol Type: %s\n", "SMIC");
>       else if (IPMI_CHANNEL_PROTOCOL_TYPE_BT_10)
>         printf ("    Protocol Type: %s\n", "BT-10");
>       else if (IPMI_CHANNEL_PROTOCOL_TYPE_BT_15)
>         printf ("    Protocol Type: %s\n", "BT-15");
>       else if (IPMI_CHANNEL_PROTOCOL_TYPE_TMODE)
>         printf ("    Protocol Type: %s\n", "TMODE");
>       else if (IPMI_CHANNEL_PROTOCOL_TYPE_IS_OEM(channel_info_list
> [i].protocol_type))
>         printf ("    Protocol Type: %s\n", "OEM");
> 
> Most of the "else if" statements look wrong.  I believe they have to be
> masked with something.
> 
> I will open a bug too.
> 
> Al
> 
-- 
Albert Chu
address@hidden
925-422-5311
Computer Scientist
High Performance Systems Division
Lawrence Livermore National Laboratory