Re: [Freeipmi-devel] bmc-config: PEF config checkout

[Al Chu]

Hi Ingo,

Great.  Thanks for the patch.

> - Several *_commit functions in bmc-sol-conf-section.c used to
>    free the kv->value before actually parsing it, resulting in
>    the actual parameter being set to 0.

ARGH!  This code worked on another machine.  I suppose the randomness
of the compile/memory usage would allow the value read from the
invalid pointer to still be correct for other machines.

Do you believe this was the cause of the bug I reported to you guys?

Al

On Tue, 2006-09-05 at 16:20 +0200, Ingo van Lil wrote:
> Albert Chu <address@hidden> schrieb:
> 
> > Thanks Ingo.  Great catches.  I've checked all your changes in.
> 
> Found a few more bugs today:
> 
> - One of the fields in
>    tmpl_cmd_set_pef_configuration_parameters_pef_startup_delay_rq
>    was misnamed.
> - The Power_Restore_Policy in the Misc section is now commented
>    out if the BMC reports it as unknown.
> 
> Cheers,
> Ingo
-- 
Albert Chu
address@hidden
925-422-5311
Computer Scientist
High Performance Systems Division
Lawrence Livermore National Laboratory