[Freeipmi-devel] Re: now ipmi-sel is in C

[Al Chu]

Hey Bala,

The issue is that this was a maintenance branch, so that code should
have never been "cleaned up", if there were actually no bugs.

I still think we should still revert the code, so that the differences
between the different releases are still kept to a minimum.

Al

On Fri, 2006-07-07 at 18:39 -0700, Bala.A wrote:
> Hi Al,
> 
> packet retransmission code is only in UDM.  I did code cleanup in
> ipmi_lan_sendto() and forgot to initialize packet_size variable.  Because
> of that, ipmi_lan_sendto() was failing.
> 
> Thanks,
> 
> Bala
> ---
> Free as in freedom
> http://www.gnu.org/
> 
> 
> > On Fri, 2006-07-07 at 15:20 -0700, Anand Babu wrote:
> >> This bug was introduced because of re-transmission feature. I thought,
> >> that feature was required, so we fix the bug.
> >
> > These functions were nearly entirely re-written.  I have no idea why.
> >
> > All retransmission code should only be in the UDM code.  None of it
> > should be in ipmi_lan_sendto().  The ipmi_lan_sendto() in 0.3.0 is still
> > the same as the code in 0.2.0.
> >
> > Al
> >
> > --
> > Albert Chu
> > address@hidden
> > 925-422-5311
> > Computer Scientist
> > High Performance Systems Division
> > Lawrence Livermore National Laboratory
> >
> >
> 
> 
-- 
Albert Chu
address@hidden
925-422-5311
Computer Scientist
High Performance Systems Division
Lawrence Livermore National Laboratory