Re: [Freeipmi-devel] the new ipmi_kcs_io_init API

[Anand Babu]

,----[ Albert Chu <address@hidden> ]
| I find the new interface a bit odd.  I don't quite understand why we
| should pass in some #define value for regspacing which gets converted
| into a different value, but the sms_io_base is read in as is.  I think
| the second parameter of the function should instead be
| "reg_byte_spacing", and the user can pass in 1, 2, 4, 16, etc.
`----
It was because I am trying to abstract as much as details inside the
KCS driver itself. Otherwise it would require user to understand the
conversion of ipmi-locate bit fields and pass appropriate value.

Current approach is, You can directly pass the ipmi-locate value.

ipmi_probe (ipmi_interface_kcs, &probeinfo, &status);
if (status == 0 && !probeinfo.bmc_io_mapped)
    ipmi_kcs_io_init(probeinfo.base.bmc_iobase_addr, probeinfo.reg_space, 
IPMI_KCS_SLEEP_USECS))






-- 
Anand Babu
Free as in Freedom <www.gnu.org>