[Freeipmi-devel] [bugs #8414] Poor handling of values that can only be set on certain platforms

[Anand Babu]

This mail is an automated notification from the bugs tracker
 of the project: FreeIPMI.

/**************************************************************************/
[bugs #8414] Latest Modifications:

Changes by: 
                Anand Babu <address@hidden>
'Date: 
                Thu 04/15/04 at 08:38 (GMT)

            What     | Removed                   | Added
---------------------------------------------------------------------------
          Resolution | None                      | Wont Fix
         Assigned to | None                      | ab
              Status | Open                      | Closed


------------------ Additional Follow-up Comments ----------------------------
Current error handler is good enough. Discussed on the mailing list.






/**************************************************************************/
[bugs #8414] Full Item Snapshot:

URL: <http://savannah.nongnu.org/bugs/?func=detailitem&item_id=8414>
Project: FreeIPMI
Submitted by: Joseph Ruscio
On: Thu 04/01/04 at 17:33

Category:  bmc-config
Severity:  5 - Average
Item Group:  User Interface Bug
Resolution:  Wont Fix
Assigned to:  ab
Status:  Closed


Summary:  Poor handling of values that can only be set on certain platforms

Original Submission:  The file containg the current configuration of the BMC 
output from executing contains a comment for each option, listing all 
acceptable values. 

Many of the configuration options do not accept all of the values listed in the 
comments. I assume this is a platform specific situation. Currently attmpeting 
to set these values result in errors of the following types:

error: ipmi_kcs_set_user_access: 204: Invalid data field in Request.

error: ipmi_lan_set_ip_addr_source: 204: Invalid data field in Request.

These are cryptic and should be replaced with something similar to this:

"Unable to set requested <KEY> to <VALUE> either due to specific platform 
restrictions or value being invalid."



Follow-up Comments
------------------


-------------------------------------------------------
Date: Thu 04/15/04 at 08:38         By: ab
Current error handler is good enough. Discussed on the mailing list.

-------------------------------------------------------
Date: Tue 04/13/04 at 18:38         By: chu11
I think we should try and do user-level checks to make sure values are as 
correct as can be.  For example:

tdev3|/home/achur 116>/usr/sbin/bmc-config --diff -f conf-new
BMC:  callback_level.max_privilege_auth_type.none 0
USER: callback_level.max_privilege_auth_type.none 9

tdev3|/home/achur 117>/usr/sbin/bmc-config --commit -f conf-new

We can atleast check that user has input 0 or 1.


-------------------------------------------------------
Date: Tue 04/06/04 at 00:22         By: jruscio
I didn't expect that we could determine exact ranges, I just don't like seeing 
libfreeipmi function names in user level error messages. So yes, it is simply a 
matter of style.

-------------------------------------------------------
Date: Mon 04/05/04 at 23:32         By: ab
                                                                                
            IPMI Spec doesn't define valid input range clearly for all settable 
parameters.
                                                                                
            
BMC can only try the user fed value and see if BMC returns
"Invalid Data" error code.
                                                                                
            
I think main argument is about beautifying error messages.
It is a matter of policy and style :).


-------------------------------------------------------
Date: Mon 04/05/04 at 23:21         By: ab
Current error handler is generic and can exactly translate  BMC's error 
response code to some meaningful English text like "Invalid data field in 
Request". Actual possibilities are huge.
                                                                                
            












For detailed info, follow this link:
<http://savannah.nongnu.org/bugs/?func=detailitem&item_id=8414>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/