[Freeipmi-devel] Re: My plans

[Albert Chu]

> You can get a snapshot of untested code at 
> ftp://ftp.cdclinux.com/pub/ipmi/libfreeipmi-0.0.0-19Jan04.tgz
> (for review purpose only)

I don't have a lot of time to review it right now b/c of the
power control problem on thunder, but here are some initial thoughts.

1) Why do you hide the fiid_template_t definitions inside the .c files?
 Doesn't this remove the point of having "structures" users can
manipulate themselves instead of using our helper functions??

2) Almost all the functions take a "fiid_obj_t obj_hdr" or similar
parameter, but no "obj_hdr_len" or similar parameter.  Is the buffer
length checked at any point internally in the fiid code base?  If
not, I am really against having an API like this.  I talked to others
here, and having a function that doesn't pass in a buffer length (or
hide a buffer length internally within the abstract type) is destined
for bugs and problems.

3) I am a little confused about your vision for the ipmi-lan API, could
you give me an example??

> Currently I am also merging code from freeipmi-utils package. We will
> be ready for a public pre0 release after that.

I thought the freeipmi-utils package was supposed to be a set of
temporary tools to help configure the BMCs for thunder.  Why would we
need to release them??  Isn't fish supposed to be the primary deliverable??

Al

--
Albert Chu
address@hidden
Lawrence Livermore National Laboratory

----- Original Message -----
From: Anand Babu <address@hidden>
Date: Tuesday, January 20, 2004 2:37 pm
Subject: My plans

> You can get a snapshot of untested code at 
> ftp://ftp.cdclinux.com/pub/ipmi/libfreeipmi-0.0.0-19Jan04.tgz
> (for review purpose only)
> 
> By tomorrow hopefully I will also merge SEL support into the core.
> and make a commit.
> 
> Currently I am also merging code from freeipmi-utils package. We will
> be ready for a public pre0 release after that.
> 
> Between pre0 and pre3 I will finish FreeIPMI Hackers guide.
> 
> Jim,
> We will discuss IPMI Platform Event Manager strategy in a separate
> thread.
> 
> -- 
> _.|_ 
> (_||_)
> Free as in Freedom <www.gnu.org>
>