[Freeipmi-devel] Re: [llnl-devel] New FreeIPMI API thouoghts

[Albert Chu]

> >assemble_pkt(rmcp_hdr_t *rmcp_hdr, ipmi_session_t *ipmi_session,
> >             ipmi_request_hdr_t *ipmi_rq, void *ipmi_cmd, int 
> >             ipmi_cmd_len, void *buffer, int buflen);
> >
> >To some extent mirror the unassemble functions.
> 
> You mean assemble_pkt will only memcpy those structures into a
> byte-array and we will have to fill the values from outside?

That or the assemble_pkt function returns the data it put into the
buffer into the rmcp_hdr, ipmi_session header, and ipmi_request header.
  Right now, the user has no way to access the session header, request
header, or rmcp header information.  I think that is completely
unacceptable.  Most of the time, a user/we won't need to access that
information.  But the first time that we need to, we're screwed ...

Al 

--
Albert Chu
address@hidden
Lawrence Livermore National Laboratory

----- Original Message -----
From: Anand Babu <address@hidden>
Date: Thursday, December 4, 2003 5:51 pm
Subject: Re: [llnl-devel] New FreeIPMI API thouoghts

> Albert Chu <address@hidden> writes:
> >Good point.  However, I still find it unacceptable that that request
> >packets are created such that session or request header data cannot
> >be accessed in a clean manner.  Perhaps the interface should be made
> >something like:
> >
> 
> 
> >Then perhaps we need a "ping_assemble" function of some sort.  
> Requiring>the user to do as you have in your ipmi-wrappper.c:
> >
> >  struct {
> >    rmcp_hdr_t rmcp_hdr;
> >    rmcp_asf_presence_ping_t asf_presence_ping;
> >  } lan_pkt;
> >
> >  rmcp_asf_hdr (&lan_pkt.rmcp_hdr);
> >  rmcp_asf_presence_ping (msg_tag, &lan_pkt.asf_presence_ping);
> >  ipmi_lan_sendto(fd, &lan_pkt, sizeof(lan_pkt));
> >
> >I think is too much ... especially making the lan_pkt structure.
> 
> Yes, thats right. We need to write ping_assemble function.
> 
> 
> -- 
> Anand Babu
> CaliforniaDigital.com
> Office# +1-510-687-7045
> Cell# +1-510-396-0717
> Home# +1-510-894-0586
> 
> Free as in Freedom <www.gnu.org>
>