[Freebangfont-devel] [Bug 118297] New - Double rendering of Yaphala mark

[bugzilla-daemon]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

http://bugzilla.gnome.org/show_bug.cgi?id=118297

Changed by address@hidden

--- shadow/118297       Fri Jul 25 09:48:57 2003
+++ shadow/118297.tmp.26219     Fri Jul 25 09:48:57 2003
@@ -0,0 +1,89 @@
+Bug#: 118297
+Product: pango
+Version: 1.2.x
+OS: Linux
+OS Details: 
+Status: NEW   
+Resolution: 
+Severity: normal
+Priority: Normal
+Component: general
+AssignedTo: address@hidden                            
+ReportedBy: address@hidden               
+TargetMilestone: ---
+URL: 
+Cc: address@hidden,address@hidden,address@hidden
+Summary: Double rendering of Yaphala mark
+
+Trying to keep track of the four different issues in 
+bug 113551 was pretty much impossible for me, so splitting
+up the comments into separate bug reports.
+
+* address@hidden (Sayamindu Dasgupta):
+
+1. Yaphala
+---------------
+a. The string য্য is rendered incorrectly. For some
+reasons, the Yafala mark
+is getting rendered twice.    
+    More information on yaphala can be found at
+    http://www.microsoft.com/typography/otfntdev/bengalot/features.htm
+    (section on "Post-base form of consonant")
+
+* Additional Comments From Taneem Ahmed 2003-05-31 21:30:
+
+Here is a small patch for 1a. This seems like a problem with indic-ot, not 
+just Bengali. I am not quite sure if the patch is correct for other languages 
+but it works for Bengali, and I am hoping it will give Owen some 
+indication about what is the real problem. 
+
+* Additional Comments From Owen Taylor 2003-06-01 01:22:
+
+I don't think the patch is quite right, having multiple post
+base forms is allowed in Bengali, I believe, and your
+patch will prevent such cases from rendering correctly.
+
+See: 
+
+http://oss.software.ibm.com/cvs/icu/icu/source/layout/IndicReordering.cpp.diff?r1=1.8&r2=1.9
+
+For how the problem was fixed in ICU. The immediately relevant
+part of the patch is the change:
+
+- while (baseConsonant >= baseLimit) {
++ while (baseConsonant > baseLimit) {
+
+But probably the other parts of the patch need to be ported to 
+Pango as well.
+
+* Additional Comments From Taneem Ahmed 2003-06-01 01:32:
+
+I am quite sure (99%) you can't have multiple post-base in Bengali (I am 
+not sure about other indic languages). In Bengali only 0x09AF has 
+post-base form, and I haven't seen any word where it repeats itself. I am 
+not sure how to test the other languages. 
+ 
+I'll try out what you mentioned Owen, but I doubt I can port all the 
+changes from ICU to Pango anytime soon... 
+
+* Additional Comments From Taneem Ahmed 2003-06-01 02:10
+
+Okay, seems like there weren't too many ICU changes for the reorder 
+function. Attached is the port of the diff you pointed out. Please take a 
+look and see if you can come up with an official patch some time soon. 
+
+* Additional Comments From Owen Taylor 2003-06-01 04:04
+
+I've attached two copies of a version of version of
+your backport - the first for legibility is with diff -w,
+(ignore whitespace),the second is a diff that can be applied.
+
+Changes from your version:
+
+ - Remove 'if (lastConsonant >= prev) {' and reindent
+ - Get the other part of the ICU change (remove pstf from base
+   consonants) as well.
+ - Remove code that you only #if 0'ed.
+
+If you could check whether this fixes 1a for you, that
+would be appreciated.