Re: [Findutils-patches] [PATCH] maint: avoid error from sc_prohibit_gnu_make_extensions

[Bernhard Voelker]

On 9/3/19 10:20 PM, Bernhard Voelker wrote:
> Since last gnulib update, the above syntax-check rule fails:
> 
>   Error: doc/Makefile: $< in a non implicit rule
>   find_mono.html: find.texi
>   ...
>   make: *** [maint.mk:439: sc_prohibit_gnu_make_extensions] Error 1
> 
> * doc/Makefile.am (find_mono.html): Avoid $< in plain rules.
> (findutils.texi_html_node.tar.gz): Likewise.
> 
> See also: <https://lists.gnu.org/r/bison-patches/2019-05/msg00017.html>
> ---
>  doc/Makefile.am | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/doc/Makefile.am b/doc/Makefile.am
> index 21c8e8de..d53fed42 100644
> --- a/doc/Makefile.am
> +++ b/doc/Makefile.am
> @@ -52,7 +52,7 @@ find.txt: find.texi $(srcdir)/version.texi $(find_TEXINFOS)
>  find_mono.html: find.texi
>       rm -rf $(@:.html=.htp)
>       if $(MAKEINFOHTML) --no-split $(AM_MAKEINFOHTMLFLAGS) $(MAKEINFOFLAGS) 
> -I $(srcdir) \
> -      -o $(@:.html=.htp) $<; \
> +      -o $(@:.html=.htp) find.texi; \
>       then \
>         rm -rf $@; \
>         if test ! -d $(@:.html=.htp) && test -d $(@:.html=); then \
> @@ -70,7 +70,7 @@ find_mono.html: find.texi
>  # by the maintainer, and we don't need to build the file
>  # for "make all" or "make install" (or even "make check").
>  findutils.texi_html_node.tar.gz: find.html
> -     tar zcf $@ $<
> +     tar zcf $@ find.html
>  
>  
>  dblocation.texi: ../locate/dblocation.texi

Something is fishy here.  With a 'git clean -xdfq' repo
followed by './bootstrap && ./configure && make -j20 all syntax-check',
sc_prohibit_gnu_make_extensions still fails e.g. in locate/Makefile.
Running a couple times again, the error vanishes.

This sounds like the dependencies are not correct.

I'll check next week again.

Have a nice day,
Berny