[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Findutils-patches] [PATCH] Don't return int to represent a boolean
|
From: |
Eric Blake |
|
Subject: |
Re: [Findutils-patches] [PATCH] Don't return int to represent a boolean value. |
|
Date: |
Mon, 05 Apr 2010 07:31:40 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.0.4-1.fc12 Lightning/1.0b1 Thunderbird/3.0.4 |
On 04/04/2010 04:43 PM, James Youngman wrote:
> * find/defs.h: fd_leak_check_is_enabled should return boolean, not
> int. Likewise following_links and digest_mode.
> +++ b/find/defs.h
> @@ -495,7 +495,7 @@ struct predicate *get_new_pred_chk_op PARAMS((const
> struct parser_table *entry,
> float calculate_derived_rates PARAMS((struct predicate *p));
>
> /* util.c */
> -int fd_leak_check_is_enabled (void);
> +boolean fd_leak_check_is_enabled (void);
In C99, it is spelled bool, not boolean (that is from Java). I'm not
sure where you are defining boolean, but it would be nicer to use bool
throughout.
--
Eric Blake address@hidden +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature