Re: [Findutils-patches] [PATCH] Avoid segfault in -execdir when PATH is unset.

[Eric Blake]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to James Youngman on 8/19/2007 9:29 AM:
> 2007-08-19  James Youngman  <address@hidden>
> 
>       find/parser.c (check_path_safety): Assume the path is safe is
>       $PATH is not set.  This avoids a segfault in that situation
>       and thus fixes Savannmah bug #20834.
                       ^^^^^^^^^
Fix the typo, then this looks good to commit.

Definitely safe for 4.2.x; a stable branch should never crash.

> +      /* $PATH is not set.  Assume the OS default is safe.
> +       * That may not be true on Windows, but I'm not aware 
> +       * of a way to get Windows to avoid searching the 
> +       * current directory anyway.
> +       */

The above comment does not affect Cygwin, but may be true for mingw.  But
I agree with your approach - there is no need to special case a
proprietary OS with its propensity to search the current directory first
regardless of whether $PATH is set or what it contains.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGyYiH84KuGfSFAYARAsE6AJ9HS6iey/oTkPrnWoGezTvuKMFMsACgpEH4
yiwp/0fLhZnGZiUWbDBlbBo=
=nqnn
-----END PGP SIGNATURE-----