findutils-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Findutils-patches] ./configure; make check


From: Eric Blake-1
Subject: Re: [Findutils-patches] ./configure; make check
Date: Thu, 28 Jun 2007 08:16:50 -0700 (PDT)

> > +++ find/Makefile.am    28 Jun 2007 14:48:48 -0000
> > @@ -8,7 +8,7 @@ EXTRA_DIST = defs.h $(man_MANS)
> >  INCLUDES = -I../gnulib/lib -I$(top_srcdir)/lib
> -I$(top_srcdir)/gnulib/lib
> > -I../intl -DLOCALEDIR=\"$(localedir)\"
> >  LDADD = ../lib/libfind.a ../gnulib/lib/libgnulib.a @INTLLIBS@
> >  man_MANS = find.1
> > -SUBDIRS = testsuite
> > +SUBDIRS = . testsuite
> 
> Is this really the only way to control findutils' directory traversal
> order?

Yes.  It is documented this way in automake:

| By default, Automake generates Makefiles that work depth-first in
| postfix order: the subdirectories are built before the current
| directory. However, it is possible to change this ordering. You can
| do this by putting `.' into SUBDIRS. For instance, putting `.' first
| will cause a prefix ordering of directories. 
| 
| Using 
| 
|      SUBDIRS = lib src . test
| 
| will cause lib/ to be built before src/, then the current directory will
| be built, finally the test/ directory will be built. It is customary to
| arrange test directories to be built after everything else since they
| are meant to test what has been constructed. 

And indeed, this is why I proposed the patch - without it,
'make check' in the subdirectory gets executed before
'make check' in the parent, and it is the automatic dependency
of the parents' 'make check' on 'all' that ensures the binaries
get built.  So without my patch, './configure; make check'
tries to run the testsuite prior to the binaries existing.

-- 
Eric Blake

-- 
View this message in context: 
http://www.nabble.com/.-configure--make-check-tf3994825.html#a11345096
Sent from the GNU - FindUtils - Patches mailing list archive at Nabble.com.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]