Re: [Erc-discuss] [PATCH] erc: prefer 'font-lock-face to 'face where appropriate

[Lars Magne Ingebrigtsen]

Vivek Dasmohapatra <address@hidden> writes:

> Got it - the text property alias alist isn't yet populated when
> erc is built, so 'font-lock-face doesn't serve as a fallback for
> 'face (during an emacs build).
>
> Amended the assert to (let … the alias variable, and to test for both
> 'face and 'font-lock-face.

[...]

> char-property-alias-alist is not yet set during the build,
> so we should check both the 'face property and it manually
> set alias 'font-lock-face in the cl-assert for erc-faces-in.
> ---
>  lisp/erc/erc-track.el | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)
>

[...]

>  (cl-assert
> - (let ((str "is bold"))
> -   (put-text-property 3 (length str)
> -                   'font-lock-face '(bold erc-current-nick-face)
> -                   str)
> -   (erc-faces-in str)))
> + (let ((str0 "is bold")
> +       (str1 "is bold")

Hm.  I think this belongs in the "test" directory and not in
erc-track.el, though?

Could you fix that and resubmit the entire patch again?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no