Re: GNU poke 3.90.1 "make install" failure on FreeBSD

[Bruno Haible]

On FreeBSD 14.0/powerpc64, "make install" fails:

================================================================================
$ make install
make  install-recursive
Making install in jitter
Cannot install or uninstall after configuring in sub-package
mode.
This is by design, and not an error: succeeding, so as not to
break the install or distcheck rules.
make[2]: exec(exit) failed (No such file or directory)
*** Error code 1

Stop.
make[2]: stopped in /home/bruno/poke-3.90.1.6/build-64/jitter
*** Error code 1

Stop.
make[1]: stopped in /home/bruno/poke-3.90.1.6/build-64
*** Error code 1

Stop.
make: stopped in /home/bruno/poke-3.90.1.6/build-64
================================================================================

Whereas "gmake install" (with GNU make) works:
================================================================================
$ gmake install
gmake  install-recursive
gmake[1]: Entering directory '/home/bruno/poke-3.90.1.6/build-64'
Making install in jitter
gmake[2]: Entering directory '/home/bruno/poke-3.90.1.6/build-64/jitter'
Cannot install or uninstall after configuring in sub-package
mode.
This is by design, and not an error: succeeding, so as not to
break the install or distcheck rules.
gmake[2]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64/jitter'
Making install in gl
gmake[2]: Entering directory '/home/bruno/poke-3.90.1.6/build-64/gl'
gmake  install-recursive
gmake[3]: Entering directory '/home/bruno/poke-3.90.1.6/build-64/gl'
gmake[4]: Entering directory '/home/bruno/poke-3.90.1.6/build-64/gl'
gmake[5]: Entering directory '/home/bruno/poke-3.90.1.6/build-64/gl'
gmake[5]: Nothing to be done for 'install-exec-am'.
gmake[5]: Nothing to be done for 'install-data-am'.
gmake[5]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64/gl'
gmake[4]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64/gl'
gmake[3]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64/gl'
gmake[2]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64/gl'
Making install in autoconf
gmake[2]: Entering directory '/home/bruno/poke-3.90.1.6/build-64/autoconf'
gmake[3]: Entering directory '/home/bruno/poke-3.90.1.6/build-64/autoconf'
gmake[3]: Nothing to be done for 'install-exec-am'.
 ../../build-aux/install-sh -c -d '/home/bruno/prefix64/share/aclocal'
 /usr/bin/install -c -m 644 ../../autoconf/poke.m4 
'/home/bruno/prefix64/share/aclocal'
gmake[3]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64/autoconf'
gmake[2]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64/autoconf'
Making install in maps
gmake[2]: Entering directory '/home/bruno/poke-3.90.1.6/build-64/maps'
gmake[3]: Entering directory '/home/bruno/poke-3.90.1.6/build-64/maps'
gmake[3]: Nothing to be done for 'install-exec-am'.
 ../../build-aux/install-sh -c -d '/home/bruno/prefix64/share/poke/maps'
 /usr/bin/install -c -m 644 ../../maps/elf.map ../../maps/mp3.map 
../../maps/dwarf.map '/home/bruno/prefix64/share/poke/maps'
gmake[3]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64/maps'
gmake[2]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64/maps'
Making install in pickles
gmake[2]: Entering directory '/home/bruno/poke-3.90.1.6/build-64/pickles'
gmake[3]: Entering directory '/home/bruno/poke-3.90.1.6/build-64/pickles'
gmake[3]: Nothing to be done for 'install-exec-am'.
 ../../build-aux/install-sh -c -d '/home/bruno/prefix64/share/poke/pickles'
 /usr/bin/install -c -m 644 ../../pickles/ctf.pk ../../pickles/ctf-dump.pk 
../../pickles/leb128.pk ../../pickles/bpf.pk ../../pickles/btf.pk 
../../pickles/btf-ext.pk ../../pickles/btf-dump.pk ../../pickles/bmp.pk 
../../pickles/gcov.pk ../../pickles/color.pk ../../pickles/rgb24.pk 
../../pickles/id3v1.pk ../../pickles/ios.pk ../../pickles/diff.pk 
../../pickles/pk-table.pk ../../pickles/sframe.pk ../../pickles/sframe-dump.pk 
../../pickles/orc.pk ../../pickles/time.pk ../../pickles/argp.pk 
../../pickles/pktest.pk ../../pickles/mbr.pk ../../pickles/ustar.pk 
../../pickles/mcr.pk ../../pickles/id3v2.pk ../../pickles/jffs2.pk 
../../pickles/asn1-ber.pk ../../pickles/openpgp.pk ../../pickles/search.pk 
../../pickles/riscv.pk ../../pickles/coff.pk ../../pickles/coff-i386.pk 
../../pickles/coff-aarch64.pk ../../pickles/pe.pk ../../pickles/pe-amd64.pk 
../../pickles/pe-arm.pk ../../pickles/pe-arm64.pk ../../pickles/pe-i386.pk 
../../pickles/pe-ia64.pk ../../pickles/pe-m32r.pk 
'/home/bruno/prefix64/share/poke/pickles'
 /usr/bin/install -c -m 644 ../../pickles/pe-mips.pk ../../pickles/pe-ppc.pk 
../../pickles/pe-sh3.pk ../../pickles/pe-riscv.pk ../../pickles/pe-debug.pk 
../../pickles/uuid.pk ../../pickles/redoxfs.pk ../../pickles/pcap.pk 
../../pickles/ieee754.pk ../../pickles/pdap.pk ../../pickles/iscan.pk 
../../pickles/iscan-str.pk ../../pickles/base64.pk 
../../pickles/gpt-partition-attrs.pk ../../pickles/gpt-partition-types.pk 
../../pickles/gpt.pk ../../pickles/guid.pk ../../pickles/linux.pk 
../../pickles/srec.pk ../../pickles/jojodiff.pk 
'/home/bruno/prefix64/share/poke/pickles'
gmake[3]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64/pickles'
gmake[2]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64/pickles'
Making install in gl-libpoke
gmake[2]: Entering directory '/home/bruno/poke-3.90.1.6/build-64/gl-libpoke'
gmake  install-recursive
gmake[3]: Entering directory '/home/bruno/poke-3.90.1.6/build-64/gl-libpoke'
gmake[4]: Entering directory '/home/bruno/poke-3.90.1.6/build-64/gl-libpoke'
gmake[5]: Entering directory '/home/bruno/poke-3.90.1.6/build-64/gl-libpoke'
gmake[5]: Nothing to be done for 'install-exec-am'.
gmake[5]: Nothing to be done for 'install-data-am'.
gmake[5]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64/gl-libpoke'
gmake[4]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64/gl-libpoke'
gmake[3]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64/gl-libpoke'
gmake[2]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64/gl-libpoke'
Making install in libpoke
gmake[2]: Entering directory '/home/bruno/poke-3.90.1.6/build-64/libpoke'
gmake  install-am
gmake[3]: Entering directory '/home/bruno/poke-3.90.1.6/build-64/libpoke'
gmake[4]: Entering directory '/home/bruno/poke-3.90.1.6/build-64/libpoke'
 ../../build-aux/install-sh -c -d '/home/bruno/prefix64/lib'
 /bin/sh ../libtool   --mode=install /usr/bin/install -c   libpoke.la 
'/home/bruno/prefix64/lib'
libtool: install: /usr/bin/install -c .libs/libpoke.so.1.0.0 
/home/bruno/prefix64/lib/libpoke.so.1.0.0
libtool: install: (cd /home/bruno/prefix64/lib && { ln -s -f libpoke.so.1.0.0 
libpoke.so.1 || { rm -f libpoke.so.1 && ln -s libpoke.so.1.0.0 libpoke.so.1; }; 
})
libtool: install: (cd /home/bruno/prefix64/lib && { ln -s -f libpoke.so.1.0.0 
libpoke.so || { rm -f libpoke.so && ln -s libpoke.so.1.0.0 libpoke.so; }; })
libtool: install: /usr/bin/install -c .libs/libpoke.lai 
/home/bruno/prefix64/lib/libpoke.la
libtool: install: /usr/bin/install -c .libs/libpoke.a 
/home/bruno/prefix64/lib/libpoke.a
libtool: install: chmod 644 /home/bruno/prefix64/lib/libpoke.a
libtool: install: ranlib /home/bruno/prefix64/lib/libpoke.a
rm -f /home/bruno/prefix64/share/poke/*.pk
 ../../build-aux/install-sh -c -d '/home/bruno/prefix64/lib/pkgconfig'
 /usr/bin/install -c -m 644 poke.pc '/home/bruno/prefix64/lib/pkgconfig'
 ../../build-aux/install-sh -c -d '/home/bruno/prefix64/share/poke'
 /usr/bin/install -c -m 644 ../../libpoke/pkl-rt.pk pkl-config.pk 
../../libpoke/std.pk ../../libpoke/std-types.pk 
'/home/bruno/prefix64/share/poke'
 ../../build-aux/install-sh -c -d '/home/bruno/prefix64/include'
 /usr/bin/install -c -m 644 ../../libpoke/libpoke.h 
'/home/bruno/prefix64/include'
gmake[4]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64/libpoke'
gmake[3]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64/libpoke'
gmake[2]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64/libpoke'
Making install in poke
gmake[2]: Entering directory '/home/bruno/poke-3.90.1.6/build-64/poke'
gmake  install-am
gmake[3]: Entering directory '/home/bruno/poke-3.90.1.6/build-64/poke'
gmake[4]: Entering directory '/home/bruno/poke-3.90.1.6/build-64/poke'
 ../../build-aux/install-sh -c -d '/home/bruno/prefix64/bin'
  /bin/sh ../libtool   --mode=install /usr/bin/install -c poke 
'/home/bruno/prefix64/bin'
libtool: install: /usr/bin/install -c .libs/poke /home/bruno/prefix64/bin/poke
 ../../build-aux/install-sh -c -d '/home/bruno/prefix64/share/poke/poke'
 /usr/bin/install -c -m 644 ../../poke/pk-cmd.pk ../../poke/pk-dump.pk 
../../poke/pk-save.pk ../../poke/pk-copy.pk ../../poke/pk-diff.pk 
../../poke/pk-extract.pk ../../poke/pk-scrabble.pk ../../poke/poke.pk 
../../poke/pk-settings.pk ../../poke/pk-help.pk ../../poke/pk-map.pk 
../../poke/pk-info.pk ../../poke/pk-tracer.pk ../../poke/pk-hserver.pk 
'/home/bruno/prefix64/share/poke/poke'
gmake[4]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64/poke'
gmake[3]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64/poke'
gmake[2]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64/poke'
Making install in poked
gmake[2]: Entering directory '/home/bruno/poke-3.90.1.6/build-64/poked'
gmake[3]: Entering directory '/home/bruno/poke-3.90.1.6/build-64/poked'
 ../../build-aux/install-sh -c -d '/home/bruno/prefix64/bin'
  /bin/sh ../libtool   --mode=install /usr/bin/install -c poked 
'/home/bruno/prefix64/bin'
libtool: install: /usr/bin/install -c .libs/poked /home/bruno/prefix64/bin/poked
 ../../build-aux/install-sh -c -d '/home/bruno/prefix64/share/poke/poked'
 /usr/bin/install -c -m 644 ../../poked/poked.pk ../../poked/pk-dump-minimal.pk 
'/home/bruno/prefix64/share/poke/poked'
gmake[3]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64/poked'
gmake[2]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64/poked'
Making install in pokefmt
gmake[2]: Entering directory '/home/bruno/poke-3.90.1.6/build-64/pokefmt'
gmake  install-am
gmake[3]: Entering directory '/home/bruno/poke-3.90.1.6/build-64/pokefmt'
gmake[4]: Entering directory '/home/bruno/poke-3.90.1.6/build-64/pokefmt'
 ../../build-aux/install-sh -c -d '/home/bruno/prefix64/bin'
  /bin/sh ../libtool   --mode=install /usr/bin/install -c pokefmt 
'/home/bruno/prefix64/bin'
libtool: install: /usr/bin/install -c .libs/pokefmt 
/home/bruno/prefix64/bin/pokefmt
 ../../build-aux/install-sh -c -d '/home/bruno/prefix64/share/poke/pokefmt'
 /usr/bin/install -c -m 644 ../../pokefmt/pokefmt.pk 
'/home/bruno/prefix64/share/poke/pokefmt'
gmake[4]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64/pokefmt'
gmake[3]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64/pokefmt'
gmake[2]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64/pokefmt'
Making install in utils
gmake[2]: Entering directory '/home/bruno/poke-3.90.1.6/build-64/utils'
gmake[3]: Entering directory '/home/bruno/poke-3.90.1.6/build-64/utils'
 ../../build-aux/install-sh -c -d '/home/bruno/prefix64/bin'
 /usr/bin/install -c pk-elfextractor pk-strings pk-bin2poke pk-jojopatch 
'/home/bruno/prefix64/bin'
gmake[3]: Nothing to be done for 'install-data-am'.
gmake[3]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64/utils'
gmake[2]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64/utils'
Making install in doc
gmake[2]: Entering directory '/home/bruno/poke-3.90.1.6/build-64/doc'
gmake[3]: Entering directory '/home/bruno/poke-3.90.1.6/build-64/doc'
gmake[3]: Nothing to be done for 'install-exec-am'.
 ../../build-aux/install-sh -c -d '/home/bruno/prefix64/share/poke/poke'
 /usr/bin/install -c -m 644 nodelist ../../doc/poke.text 
'/home/bruno/prefix64/share/poke/poke'
 ../../build-aux/install-sh -c -d '/home/bruno/prefix64/share/info'
 /usr/bin/install -c -m 644 ../../doc/poke.info ../../doc/poke.info-1 
../../doc/poke.info-2 ../../doc/poke.info-3 '/home/bruno/prefix64/share/info'
gmake[3]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64/doc'
gmake[2]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64/doc'
Making install in man
gmake[2]: Entering directory '/home/bruno/poke-3.90.1.6/build-64/man'
gmake[3]: Entering directory '/home/bruno/poke-3.90.1.6/build-64/man'
gmake[3]: Nothing to be done for 'install-exec-am'.
 ../../build-aux/install-sh -c -d '/home/bruno/prefix64/share/man/man1'
 /usr/bin/install -c -m 644 ../../man/poke.1 ../../man/poked.1 
'/home/bruno/prefix64/share/man/man1'
gmake[3]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64/man'
gmake[2]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64/man'
Making install in testsuite
gmake[2]: Entering directory '/home/bruno/poke-3.90.1.6/build-64/testsuite'
Making install in poke.libpoke
gmake[3]: Entering directory 
'/home/bruno/poke-3.90.1.6/build-64/testsuite/poke.libpoke'
gmake[4]: Entering directory 
'/home/bruno/poke-3.90.1.6/build-64/testsuite/poke.libpoke'
gmake[4]: Nothing to be done for 'install-exec-am'.
gmake[4]: Nothing to be done for 'install-data-am'.
gmake[4]: Leaving directory 
'/home/bruno/poke-3.90.1.6/build-64/testsuite/poke.libpoke'
gmake[3]: Leaving directory 
'/home/bruno/poke-3.90.1.6/build-64/testsuite/poke.libpoke'
gmake[3]: Entering directory '/home/bruno/poke-3.90.1.6/build-64/testsuite'
gmake[4]: Entering directory '/home/bruno/poke-3.90.1.6/build-64/testsuite'
gmake[4]: Nothing to be done for 'install-exec-am'.
gmake[4]: Nothing to be done for 'install-data-am'.
gmake[4]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64/testsuite'
gmake[3]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64/testsuite'
gmake[2]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64/testsuite'
Making install in etc
gmake[2]: Entering directory '/home/bruno/poke-3.90.1.6/build-64/etc'
Making install in vim
gmake[3]: Entering directory '/home/bruno/poke-3.90.1.6/build-64/etc/vim'
gmake[4]: Entering directory '/home/bruno/poke-3.90.1.6/build-64/etc/vim'
gmake[4]: Nothing to be done for 'install-exec-am'.
 ../../../build-aux/install-sh -c -d '/home/bruno/prefix64/share/vim/vimfiles'
 ../../../build-aux/install-sh -c -d 
'/home/bruno/prefix64/share/vim/vimfiles/ftdetect'
 /usr/bin/install -c -m 644  ../../../etc/vim/ftdetect/poke.vim 
'/home/bruno/prefix64/share/vim/vimfiles/ftdetect'
 ../../../build-aux/install-sh -c -d 
'/home/bruno/prefix64/share/vim/vimfiles/syntax'
 /usr/bin/install -c -m 644  ../../../etc/vim/syntax/poke.vim 
'/home/bruno/prefix64/share/vim/vimfiles/syntax'
gmake[4]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64/etc/vim'
gmake[3]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64/etc/vim'
gmake[3]: Entering directory '/home/bruno/poke-3.90.1.6/build-64/etc'
gmake[4]: Entering directory '/home/bruno/poke-3.90.1.6/build-64/etc'
gmake[4]: Nothing to be done for 'install-exec-am'.
 ../../build-aux/install-sh -c -d '/home/bruno/prefix64/share/poke/poke'
 /usr/bin/install -c -m 644 ../../etc/poke-dark.css ../../etc/poke-bright.css 
'/home/bruno/prefix64/share/poke/poke'
 ../../build-aux/install-sh -c -d '/home/bruno/prefix64/share/emacs/site-lisp'
 /usr/bin/install -c -m 644 ../../etc/poke-map-mode.el 
../../etc/poke-ras-mode.el '/home/bruno/prefix64/share/emacs/site-lisp'
gmake[4]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64/etc'
gmake[3]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64/etc'
gmake[2]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64/etc'
Making install in po
gmake[2]: Entering directory '/home/bruno/poke-3.90.1.6/build-64/po'
if test "poke" = "gettext-tools"; then \
  ../../build-aux/install-sh -c -d /home/bruno/prefix64/share/gettext/po; \
  for file in Makefile.in.in remove-potcdate.sin quot.sed boldquot.sed 
en@quot.header en@boldquot.header insert-header.sin Rules-quot   
Makevars.template; do \
    /usr/bin/install -c -m 644 ../../po/$file \
                    /home/bruno/prefix64/share/gettext/po/$file; \
  done; \
  for file in Makevars; do \
    rm -f /home/bruno/prefix64/share/gettext/po/$file; \
  done; \
else \
  : ; \
fi
gmake[2]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64/po'
gmake[2]: Entering directory '/home/bruno/poke-3.90.1.6/build-64'
gmake[3]: Entering directory '/home/bruno/poke-3.90.1.6/build-64'
gmake[3]: Nothing to be done for 'install-exec-am'.
gmake[3]: Nothing to be done for 'install-data-am'.
gmake[3]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64'
gmake[2]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64'
gmake[1]: Leaving directory '/home/bruno/poke-3.90.1.6/build-64'
================================================================================

But relying on GNU make is not necessary. FreeBSD make works fine,
even with a VPATH build and even with the rules that generate .c files
from .y files.

The attached patch fixes it.

Could you please apply it, Luca?

Explanation: In the do-nothing-on-sub-package-mode-install rule, like
elsewhere, each command is run by itself. Thus, when 'exit 0' succeeds,
it is a no-op. But apparently FreeBSD makes an attempt to invoke an 'exit'
program. There is none; thus it fails.

Bruno

0001-Fix-a-make-install-failure-with-FreeBSD-make.patch
Description: Text Data