Re: [PATCH] Build System Fixes

[Luca Saiu]

Thank you Darshit.  Sorry for replying so late; your contributions are
very much appreciated.

On 2020-01-28 at 16:56 +0100, Darshit Shah wrote:

> @@ -360,9 +360,9 @@ AM_CONDITIONAL([JITTER_HAVE_ACTUAL_GCC],
>  # If the compiler is actually GCC I can check its version as well.
>  if test "x$JITTER_HAVE_ACTUAL_GCC" = 'xyes'; then
>    AC_MSG_CHECKING([for GCC's version])
> -  JITTER_GCC_MAJOR_VERSION=$(echo '__GNUC__' | "$CC" -P -E -)
> -  JITTER_GCC_MINOR_VERSION=$(echo '__GNUC_MINOR__' | "$CC" -P -E -)
> -  JITTER_GCC_PATCHLEVEL_VERSION=$(echo '__GNUC_PATCHLEVEL__' | "$CC" -P -E -)
> +  JITTER_GCC_MAJOR_VERSION=$(echo '__GNUC__' | $CC -P -E -)
> +  JITTER_GCC_MINOR_VERSION=$(echo '__GNUC_MINOR__' | $CC -P -E -)
> +  JITTER_GCC_PATCHLEVEL_VERSION=$(echo '__GNUC_PATCHLEVEL__' | $CC -P -E -)
>    JITTER_GCC_COMBINED_VERSION=$(( ${JITTER_GCC_MAJOR_VERSION} * 10000 + 
> ${JITTER_GCC_MINOR_VERSION} * 100 + ${JITTER_GCC_PATCHLEVEL_VERSION}))
>    AC_MSG_RESULT([major ${JITTER_GCC_MAJOR_VERSION}, minor 
> ${JITTER_GCC_MINOR_VERSION}, patchlevel ${JITTER_GCC_PATCHLEVEL_VERSION}, 
> combined ${JITTER_GCC_COMBINED_VERSION}])
>  fi

This is already fixed now, even if in a different way and for a
different initial reason.  You were right about the quotes, of course.
But another interesting thing I learned is that
  cc -P -E
does not have the intended behavior even with old versions of GCC.

> -automake   1.9.6
> +automake   1.14
>  bison      3.0.0
> -flex       2.6.1
> +flex       2.5.37

Oh, this is good.  I had not expected to see requirements lowered.

Fixed, thanks.

-- 
Luca Saiu
* My personal web site:  http://ageinghacker.net
* GNU epsilon:           http://www.gnu.org/software/epsilon
* Jitter:                http://ageinghacker.net/projects/jitter

I support everyone's freedom of mocking any opinion or belief, no
matter how deeply held, with open disrespect and the same unrelented
enthusiasm of a toddler who has just learned the word "poo".

signature.asc
Description: PGP signature