Re: [Enigma-devel] Lua 5.1 "luaL_error" problems on Windows

[Tacvek]

----- Original Message ----- 
From: "Tacvek" <address@hidden>
To: <address@hidden>
Sent: Monday, July 24, 2006 5:56 PM
Subject: Re: [Enigma-devel] Lua 5.1 "luaL_error" problems on Windows

> >
>
> Ok. I just got an Enigma version to work correctly with a C++ lua build. 
> :D
> Works correctly as in does not crash on any of those tests.

Hmm.. no reply yet, so i'm just going to attach the patches, and 
resummarize.
Either of the patches can be used to stop the crashing on Windows.

The patch called simple compiles liblua as C++ and disables building the 
tolua++ tool
for all MingW32 compiles.

The patch named complex is my preffered patch. It adds a new configure 
option:
--enable-cxxlua/--disable--cxxlua. This option causes liblua to be compiled 
as C++
and disbales building the tolua++ tool. It defaults to disabled, except on 
MingW32,
where it defaults to enabled.

Both patches require editing two files that enigma does not own, namely 
luaconf.h
and tolua++.h.

The changes to those files only take effect when compiling as c++ so this 
should not
bother any downstreams.

However, it is a slight pain for us, as it is something we have to rember 
whenever we update
lua or tolua++. To that end, I would suggest adding a new directory to 
version control,
but not telling the build system about it, so it gets ignored and is not 
included in source tarballs,
that contains the diffs agains the clean upstream versions of those files. 
Then whenever we update
either of those we only need to remember that after copying the files over, 
we must reapply the patches.


I think we can safely say that the bug is part of MingW32 and appears to 
occur when throwing an exceptions shortly after a longjmp, under a specific 
set of circumstances.