[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Enigma-devel] Possible way to remove file_zip.cc

From: Tacvek
Subject: Re: [Enigma-devel] Possible way to remove file_zip.cc
Date: Mon, 17 Apr 2006 17:50:19 -0400

----- Original Message ----- From: "Erich Schubert" <address@hidden>
To: "Ronald Lamprecht" <address@hidden>
Cc: "Tacvek" <address@hidden>; "Daniel Heck" <address@hidden>; <address@hidden>
Sent: Monday, April 17, 2006 1:01 PM
Subject: Re: [Enigma-devel] Possible way to remove file_zip.cc

> +#include "zipios++/zipfile.h"
> +#include "zipios++/zipios-config.h.in"

The .in file should never ever be included.
If you build zipios you should however get a zipios-config.h file, that
is included in Debians zipios devel packages.

Still you shouldn't include it, because that may change in a different
the "zipfile.h" file already includes zipios-config.h

What is exactly the problem with zipfile.h?

The problem with zipfile.h is that it includes zipios-config.h
The definitions in zipios-config.h conflict with enigma's config.h definitions, causing warnings of refinining macros. The trick I used is that the a 'config.h.in' undef's
all these macros thus removing the conflict.

It is a bug that zipios++ uses a config.h that is required by annother header without using

The correct way to fix the bug would be to change the
'AC_CONFIG_HEADERS([zipios++/zipios-config.h])' line to
and to add

and then updating the uses of the constants to include

the definition and source of that autoconf macro can be found at


The autoconf macro should be addd to the acinclude.m4 file which
should be created if needed.

The annother way to remove file_zip.cc by changing only enigma code is to use AX_PREFIX_CONFIG_H
on Wnigma's own config.h

This would avoid conflicting with zipios-config.h's macro definitions.
If a patch to implement this other possibility is desired I can make


reply via email to

[Prev in Thread] Current Thread [Next in Thread]